search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 445 forks source link

UIWebView usage and ITMS-90809: Deprecated API Usage #1380

Closed nickykln closed 5 years ago

nickykln commented 5 years ago

Hello Sir @EddyVerbruggen

As you may know there is a deprecation warning sent from today related to the usage of UIWebView

I have read that firebase still contains references to this deprecated library.

https://github.com/firebase/firebase-ios-sdk/issues/3722

This issue concerns Dynamics Links but I am not using this component, that is why I am not sure that is the root cause of this warning that will be a blocking issue for AppStore submissions soon :(

"dynamic_links": false, in ny firebase.nativescript.json

If you have time to have a look ? If anyone has the same issue ?

Thanks a lot,

N

EddyVerbruggen commented 5 years ago

We'll have to wait for Google to publish a new version of their SDK first. Thx for the heads-up!

EddyVerbruggen commented 5 years ago

Almost there, see https://github.com/firebase/firebase-ios-sdk/pull/3723#issuecomment-527183143

NathanWalker commented 5 years ago

Looks like they published 6.8.0 now (https://github.com/CocoaPods/Specs/blob/master/Specs/0/3/5/Firebase/6.8.0/Firebase.podspec.json). Curious if any code changes needed you think @EddyVerbruggen or can we just bump cocoapod versions?

EddyVerbruggen commented 5 years ago

@NathanWalker Usually they break things which you may or may not notice based on the features you (don't) use.

I always wait for them to be happy with the release and post the release notes here: https://firebase.google.com/support/release-notes/ios

nuno-morais commented 5 years ago

https://firebase.google.com/support/release-notes/ios#dynamic-links

It was already updated...

EddyVerbruggen commented 5 years ago

I checked yesterday and 6.8.0 was not mentioned. Thx for the heads up!

Btw this may take me some time because there are a few nasty build errors in this release.

EddyVerbruggen commented 5 years ago

The build issues I mentioned are related to MLKit and tns-ios, but the team has solved it in 6.1.0, so if you're running tns-ios 6.1.0+ and Firebase plugin 10.0.0 you will be good. I'll release it tomorrow.

EddyVerbruggen commented 5 years ago

10.0.0 is out. Hope that helps.

nitrotm commented 4 years ago

@EddyVerbruggen I still get that message from Apple even after upgrading to 10.0.0. I have cross-checked by removing all other dependencies. Everything pass except if I add nativescript-pluging-firebase to the project.

Here's my firebase.nativescript.json:

{
    "external_push_client_only": false,
    "using_ios": true,
    "using_android": true,
    "firestore": false,
    "realtimedb": false,
    "authentication": false,
    "remote_config": false,
    "performance_monitoring": false,
    "messaging": true,
    "in_app_messaging": false,
    "crashlytics": false,
    "crash_reporting": false,
    "storage": false,
    "functions": false,
    "facebook_auth": false,
    "google_auth": false,
    "admob": false,
    "invites": false,
    "dynamic_links": false,
    "ml_kit": true,
    "ml_kit_text_recognition": false,
    "ml_kit_barcode_scanning": true,
    "ml_kit_face_detection": false,
    "ml_kit_image_labeling": false,
    "ml_kit_custom_model": false,
    "ml_kit_natural_language_identification": false,
    "ml_kit_natural_language_smartreply": false
}
nitrotm commented 4 years ago

Ok, tried with latest pods today, and it seems fixed:

Firebase (6.10.0)
FirebaseAnalytics (6.1.3)
FirebaseAnalyticsInterop (1.4.0)
FirebaseCore (6.3.1)
FirebaseCoreDiagnostics (1.1.1)
FirebaseCoreDiagnosticsInterop (1.0.0)
FirebaseInstanceID (4.2.5)
FirebaseMLCommon (0.19.0)
FirebaseMLVision (0.19.0)
FirebaseMLVisionBarcodeModel (0.19.0)
FirebaseMessaging (4.1.6)

I had the following before:

Firebase (6.9.0)
FirebaseAnalytics (6.1.2)
FirebaseAnalyticsInterop (1.4.0)
FirebaseCore (6.3.0)
FirebaseCoreDiagnostics (1.1.0)
FirebaseCoreDiagnosticsInterop (1.0.0)
FirebaseInstanceID (4.2.5)
FirebaseMLCommon (0.18.0)
FirebaseMLVision (0.18.0)
FirebaseMLVisionBarcodeModel (0.18.0)
FirebaseMessaging (4.1.5)
cuijinfeng68 commented 4 years ago

https://firebase.google.com/support/release-notes/ios#dynamic-links

It was already updated...

how to update it? pod repo update? After I update ,but it does not work.