search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 444 forks source link

Feat: extend FirebasePhoneLoginOptions with android timeout parameter #1495

Closed kanclalg closed 4 years ago

kanclalg commented 4 years ago

Possibility to pass timeout parameter for verifyPhoneNumber function. https://firebase.google.com/docs/reference/android/com/google/firebase/auth/PhoneAuthProvider.html#verifyPhoneNumber(java.lang.String,%20long,%20java.util.concurrent.TimeUnit,%20java.util.concurrent.Executor,%20com.google.firebase.auth.PhoneAuthProvider.OnVerificationStateChangedCallbacks)

EddyVerbruggen commented 4 years ago

That's a nice feature to have. Can you please also add that to the readme? For inspiration also checkout this bit in the page you linked to:

the maximum amount of time you are willing to wait for SMS auto-retrieval to be completed by the library. Maximum allowed value is 2 minutes. Use 0 to disable SMS-auto-retrieval. Setting this to 0 will also cause onCodeAutoRetrievalTimeOut(String) to be called immediately. If you specified a positive value less than 30 seconds, library will default to 30 seconds.

kanclalg commented 4 years ago

@EddyVerbruggen, updated the readme and added documentation for the property

EddyVerbruggen commented 4 years ago

That looks really god, thanks a lot!

kanclalg commented 4 years ago

@EddyVerbruggen, could you please share when are you planning to release 10.2.1 version?

EddyVerbruggen commented 4 years ago

It's not planned yet, but if you're in a rush then I'l release it today.

kanclalg commented 4 years ago

Would be great if you could release it today

EddyVerbruggen commented 4 years ago

Testing a few things, should be close now.

EddyVerbruggen commented 4 years ago

OK, released!