search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 446 forks source link

FirebaseHttpMetric does not support setting responsePayloadSize #1633

Open jalberto-ghub opened 4 years ago

jalberto-ghub commented 4 years ago

There seems to be a missing method on FirebaseHttpMetric to allow setting up the responsePayloadSize. There are underlying methods or properties on the wrapped native objects for both android and iOS, but to way to set them up.

This is particularly important as you do not get monitoring of HTTP/s requests out of the box on Android which means one needs to do it by hand in an interceptor or something similar. Without this method, there is no way to obtain accurate information on the firebase console.

EddyVerbruggen commented 4 years ago

Would you be up for a PR perhaps?

jalberto-ghub commented 4 years ago

It would be my first on GitHub as we don't use it at work, but the change is really minuscule. Let me take a look what it entails to set me up.