search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

Disable Direct Channel API on iOS #1641

Closed shahen94 closed 4 years ago

shahen94 commented 4 years ago

Direct Channel API is deprecated and will be removed in the next releases of the FirebaseSDK

Same issue on React-Native https://github.com/invertase/react-native-firebase/issues/3674 https://github.com/invertase/react-native-firebase/pull/3733

Closes #1609

EddyVerbruggen commented 4 years ago

@shahen94 Thanks!

According to https://firebase.google.com/docs/reference/ios/firebasemessaging/api/reference/Classes/FIRMessaging#shouldestablishdirectchannel the false / 'NO' value is the default, so you might as well remove those 3 lines entirely.

shahen94 commented 4 years ago

Good catch! @EddyVerbruggen done

EddyVerbruggen commented 4 years ago

Excellent, thank you!

felixkrautschuk commented 3 years ago

@EddyVerbruggen is there a plan when this fix will be published? and will that fix be available for the NS 6 compatible version of this plugin?