search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

NS7+Ng10 Admob Smartbanner error: Invalid ad width or height: (0, 0) on v11.0.0 (iOS 14 only) #1683

Open ngocnt1 opened 3 years ago

ngocnt1 commented 3 years ago

√ Getting NativeScript components versions information... √ Component nativescript has 7.0.8 version and is up to date. √ Component @nativescript/core has 7.0.7 version and is up to date. √ Component @nativescript/ios has 7.0.0 version and is up to date. √ Component @nativescript/android has 7.0.0 version and is up to date.

iOS 14.0+, @nativescript/firebase@^11.0.0

i got "Invalid ad width or height: (0, 0)" all the times with smart banner request. it works well with normal banner.

ngocnt1 commented 3 years ago

Hi @EddyVerbruggen , i investigated this issue on my app, i found initWithAdSizeOrigin is no longer return Bannerview with correct AdSize, that why it's throwing "Invalid ad width or height: (0, 0)" when my app try to get a smart banner ad.

i want to create an PR but i don't now where is the v11.0.0 branch for NS7.

EddyVerbruggen commented 3 years ago

Hi! Feel free to send it to master instead.

ngocnt1 commented 3 years ago

Hi @EddyVerbruggen , do you have a second to have a look on this? i still got stuck with the smartbanner ads on 11.1.3 if without this PR