fix(ios): FirebaseCrashlytics release mode and delegate handling improvements

NathanWalker commented 3 years ago

[x] fixes FirebaseCrashlytics import in release mode (see attachments) - When building in release mode for store upload the module import would cause error
[x] improves delegate handling to retain on the firebase symbol to avoid occasional early garbage collection by v8 engine
[x] fixes random crash when trying to login with Google on iOS with {N} 7

This is published under rc right now with @nativescript/firebase 11.1.1-rc.0 if anyone experiences issues related to above can try and please confirm here if it solved it for you.

romandrahan commented 3 years ago

It looks like https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/1640#issuecomment-717786277 has been resolved here 👍

EddyVerbruggen commented 3 years ago

Ah, nice, I missed this PR and fixed that first issue in the same way :) Merging! Thank you @NathanWalker!

EddyVerbruggen commented 3 years ago

@lambourn lol, that's probably why Github says there's a merge conflict on that line :)

EddyVerbruggen / nativescript-plugin-firebase

fix(ios): FirebaseCrashlytics release mode and delegate handling improvements #1714