search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

Fix bug on iOS platform occurring when application is built in releas… #1718

Closed Execomsrl closed 3 years ago

Execomsrl commented 3 years ago

Fix bug on iOS platform occurring when application is built in release mode with development environment. In this case, before this patch, the plugin copies firebase prod file in place of the firebase dev file.

mapo80 commented 3 years ago

We need this fix to be merged! Good fix. It would be great if this fix will be available for NS 6.x too.

mapo80 commented 3 years ago

Hi @EddyVerbruggen, thanks for accepting this PR. Do you plan to release it on 10.6.x version. I hope so.

Thanks very much.

Execomsrl commented 3 years ago

Thanks for merging the fix. Can you apply it to 10.6 version too? I'm actually using that version and it would be great if i could use the fix there too. Thanks.

EddyVerbruggen commented 3 years ago

For 10.6 you should point a PR to the 10.6 maintenance branch ;) I'd be happy to merge it of course.

Execomsrl commented 3 years ago

For 10.6 you should point a PR to the 10.6 maintenance branch ;) I'd be happy to merge it of course.

I sent a new PR to fix the bug even in 10.6 branch. Thanks.