EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

Fix after-prepare hook doesn't check if release build to determine env #1774

Open delaneyb opened 3 years ago

delaneyb commented 3 years ago

The current after-prepare hook's check to determine what env - 'production' or 'development' - it is building for does not match the check used in the before-checkForChanges hook. Specifically, it does not identify we are performing a production build if the release flag is set, unless env.production or env.prod are specified.

I have also simplified and made sure the way isProdEnv and isStagingEnv are computed is consistent across the two scripts.