search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

[Docs] Add Note That Some Features Required Additional Configuration #1814

Closed joshmossas closed 3 years ago

joshmossas commented 3 years ago

This pull request adds a note to the readme under "Config" that some features (specifically Admob) may require additional configuration. I've added this because I and a couple other newcomers wasted a lot of time trying to understand why our app was immediately crashing after installing this plugin, only to realize that it was because I had enabled Admob in the firebase.config.json. There's no indication in the install / configuration instructions that enabling a feature might lead to problems like that, hence this PR. Hopefully this addition to the readme will spare others the wasted time.

Related issue: https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/1808

In the future I think it would be good to throw some sort of error if a feature has been enabled in the firebase.config.json but setup for that feature hasn't been completed.

EddyVerbruggen commented 3 years ago

Thanks, merged! Although, as you mentioned, adding a note to the installer would be even better.