search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 448 forks source link

Update Facebook SDK to latest #1852

Open abhayastudios opened 2 years ago

abhayastudios commented 2 years ago

Android version was pinned to v5 whereas Facebook recently requires a more recent version (latest major is v12) due to security considerations where the previously used webview is not allowed anymore and prevents Android users from using FB auth.

brendonwm commented 2 years ago

https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/1858

delaneyb commented 2 years ago

facebook-login v12 introduces a transitive dependency via facebook-common on androidx.fragment 1.3.0 that breaks navigation in nested frames, as @nativescript/core and @nativescript/android expect 1.2.5 which doesn't cause the issue. Here is an alternate PR for 11.+: https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/1868 that still resolves the webview issue but doesn't have the fragment dep.