search

EddyVerbruggen / nativescript-secure-storage

:closed_lock_with_key: NativeScript plugin for secure local storage of fi. passwords
MIT License
111 stars 26 forks source link

Async Operations? #29

Closed tomfaltesek closed 5 years ago

tomfaltesek commented 5 years ago

Hi Eddy. Thanks for your hard work on this plugin.

I took a quick peek at the source to see how we're handling sync vs. async operations and I couldn't actually find any real async operations. It looks like the async APIs simply do the exact same thing as the sync operations, but they're wrapped in a promise.

Is there any reason for a consumer of this plugin to leverage the async methods over the sync methods? Let me know if I'm mistaken here.

EddyVerbruggen commented 5 years ago

If you want to have your code execution halted during usage of this plugin, you can use the sync version. Nothing special, just that.

tomfaltesek commented 5 years ago

Yes -- Fair enough. I guess I expected there to be async options for Hawk and Conceal. Overthinking it, I suppose.

Thanks for your reply.