search

EddyVerbruggen / nativescript-secure-storage

:closed_lock_with_key: NativeScript plugin for secure local storage of fi. passwords
MIT License
111 stars 26 forks source link

iOS Default Keychain Access is Deprecated #32

Closed ScottAtRedHawk closed 4 years ago

ScottAtRedHawk commented 4 years ago

Hi @EddyVerbruggen , I just wanted to let you know that in the readme is says the default iOS keychain access is kSecAttrAccessibleAlwaysThisDeviceOnly, which is deprecated (https://developer.apple.com/documentation/security/ksecattraccessiblealwaysthisdeviceonly). I think a better default might be kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly (https://developer.apple.com/documentation/security/ksecattraccessibleafterfirstunlockthisdeviceonly).

Thanks for the work you put into these plugins!

EddyVerbruggen commented 4 years ago

Looks like you're right, thanks for the heads-up! I'll release a new version in a minute.

ScottAtRedHawk commented 4 years ago

@EddyVerbruggen You may want to update this section of the README.md https://github.com/EddyVerbruggen/nativescript-secure-storage/blob/master/README.md#ios-security with regards to this issue. Thanks!

EddyVerbruggen commented 4 years ago

Yeah you're right.. want to send a PR?