search

Eden-Kramer-Lab / spectral_connectivity

Frequency domain estimation and functional and directed connectivity analysis tools for electrophysiological data
GNU General Public License v3.0
121 stars 43 forks source link

lru_cache decorator; removed __dir__ #13

Closed dizcza closed 4 years ago

dizcza commented 4 years ago

As you asked, Not sure how much it helps though.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.5%) to 74.64% when pulling d9b197dc7a2e73609ad66b2aaa0f6e891a933526 on dizcza:lru_cache into b7a469b0e89b3bd61d191bd65d10af7aa723f746 on Eden-Kramer-Lab:master.

edeno commented 4 years ago

That's perfect. And it is a help. Thank you!

dizcza commented 4 years ago

Having read more about lru_cache, I came to the conclusion that it might be not a good idea to use lru_cache for large objects. Because it leaks the memory. See here and here. So if spectral_connectivity is an intermediate step for someone, he/she will be in trouble.

I also found joblib as an alternative.

Just for you to know.