search

Eden-Kramer-Lab / spectral_connectivity

Frequency domain estimation and functional and directed connectivity analysis tools for electrophysiological data
GNU General Public License v3.0
121 stars 43 forks source link

[JOSS] double check CITATION.cff and prepare transparent "author" requirements #41

Closed sappelhoff closed 1 year ago

sappelhoff commented 1 year ago

See for example:

https://github.com/Eden-Kramer-Lab/spectral_connectivity/blob/d4ade18825c63050e3297909e64232c547178c5c/CITATION.cff#L25

I think you can be more specific in what license you use: According to https://github.com/citation-file-format/citation-file-format/blob/main/schema-guide.md#license, and your LICENSE file, it should be: GPL-3.0

Apart from that I see that you have had one more person who committed code to this repo (dizcza <dizcza@gmail.com>) but they are not in the CITATION.cff file (and not in the JOSS publication). If this is a conscious decision, it may be good to clarify in your CONTRIBUTORS.md file, at what point contributors are considered co-authors of the software.

xref: https://github.com/openjournals/joss-reviews/issues/4840

edeno commented 1 year ago

dizcza had only minimally contributed and had declined participation in the paper. However, I will add clarification in the CONTRIBUTORS.md

edeno commented 1 year ago

@sappelhoff addressed authorship in ac925cf44a3b9cb5d12b22ca22a8a20370b03557.