[JOSS] Axes for expectation`time_trials_tapers`

Eden-Kramer-Lab / spectral_connectivity

Frequency domain estimation and functional and directed connectivity analysis tools for electrophysiological data

GNU General Public License v3.0

121 stars 43 forks source link

[JOSS] Axes for expectation`time_trials_tapers` #44

Closed EtienneCmb closed 1 year ago

EtienneCmb commented 1 year ago

Hi everyone,

For the review in JOSS (https://github.com/openjournals/joss-reviews/issues/4840), could you check the axes used for averaging when expectation is time_trials_tapers, I think it should be (0, 1, 2) and not (1, 2, 3). Is it intentional to not mention this option in the doc of the Connectivity class?

edeno commented 1 year ago

Yes, that somehow snuck in. Thanks for catching that. Fixed by 5dc0b966b366c6e58bb7531486ef25d6b50d5131