Closed EtienneCmb closed 1 year ago
That seems like a sensible change. The PLV can be used directionally so think I was aiming to leave it flexible, but people probably expect it to be the undirected version.
@EtienneCmb should be fixed in 649db3e2a595862f771ac5b4585f33d3dfff8c33
The
phase_locking_value
method returns complex value because thenp.abs
is missing. I guess you made this choice because it's then used in the ppc but from the user side, especially for non-expert, it might be confusing.A quick fix could be to have a
_phase_locking_value
without the absolute value and with :And the ppc could use
_phase_locking_value
method instead. What do you think?JOSS reference (https://github.com/openjournals/joss-reviews/issues/4840),