search

EdenEast / nightfox.nvim

🦊A highly customizable theme for vim and neovim with support for lsp, treesitter and a variety of plugins.
MIT License
3.09k stars 141 forks source link

Custom lualine separators look out of place in inactive windows #237

Closed AlxHnr closed 1 year ago

AlxHnr commented 1 year ago

Description

It is pretty common to use the symbols / or / as the separators in lualine. They look broken when displayed in inactive windows. This change happened with 9df01a3.

Behavior

Expected behavior

Lualine separators in inactive windows look subtle and don't pop into your face.

before-default before

Screenshots

Lualine separators are out of place. Text in lualine_a and lualine_z is unreadable and needs more contrast.

after-default after

Configuration

Reproduce

  1. Install the latest nightfox.nvim
  2. Install lualine and make sure line separators show up in inactive windows: 
    local lualine_section_opts = { lualine_a = {{ 'mode' }} }
require('lualine').setup{ inactive_sections = lualine_section_opts }

Additional info / context

Setup used for reproducing the issue:

EdenEast commented 1 year ago

I have created a pr to help address this. Please let me know if it solves your issue.

AlxHnr commented 1 year ago

Thanks! Works now.