bug: Bright terminal themes text color is to close to the background color

[ThorstenRhau]

Neovim version (nvim -v)

0.9.0

Operating system/version

macOS 13.3.1

Describe the bug

When using the Dayfox variant of this theme in Wezterm some of the colors are unreadable since they are too close to the background color. This affects terminal applications such as WeeChat (IRC client) where some content is "invisible" due to the text color and the background color being almost the same.

I have played around a bit with the colors to make them more readable, please find an example (that works for me) below:

*** Original values:

ansi = ["#352c24", "#a5222f", "#396847", "#ac5402", "#2848a9", "#6e33ce", "#287980", "#f2e9e1"]

brights = ["#534c45", "#b3434e", "#577f63", "#b86e28", "#4863b6", "#8452d5", "#488d93", "#f4ece6"]

*** Darker values proposed by me, only the last ansi and bright values have been changed ansi = ["#352c24", "#a5222f", "#396847", "#ac5402", "#2848a9", "#6e33ce", "#287980", "#b5ada4"] brights = ["#534c45", "#b3434e", "#577f63", "#b86e28", "#4863b6", "#8452d5", "#488d93", "#ccc4be"]

To the best of my knowledge this problem does only exist in the light variants of this theme, Dayfox and Dawnfox.

Steps To Reproduce

Use Wezterm (I assume that this is true for all terminal themes) to launch WeeChat or any other text based application that uses bright colors.

Notice that all the bright (yellow) colors that are defined in the last column of the ANSI and BRIGHT rows of the theme are not visible on screen.

Expected Behavior

The bright (Dayfox and Dawnfox) terminal themes should not use text colors that are to close to the background color.

[ThorstenRhau]

Here is a picture that shows the original and darker, proposed, colors.

[ThorstenRhau]

Let me know if I can provide any additional information.