EdenEast / nightfox.nvim

🦊A highly customizable theme for vim and neovim with support for lsp, treesitter and a variety of plugins.
MIT License
2.86k stars 134 forks source link

bug: Dayfox and Dawnfox colors are nothing like in screenshots #389

Closed herrbischoff closed 6 months ago

herrbischoff commented 6 months ago

Neovim version (nvim -v)

NVIM v0.9.4

Operating system/version

macOS 14.1.2

Describe the bug

After installing, the colors are not at all like shown in the screenshots. Check with and without tmux, in iTerm 2, Alacritty and Kitty and with a minimal config. Also, the iTerm 2 color scheme doesn't appear to reflect the refactored values yet. Lualine's colors are completely off.

Dayfox:

Screenshot 2023-12-16 at 22 22 09

Dawnfox:

Screenshot 2023-12-16 at 22 22 28

Steps To Reproduce

  1. Install nightfox via Lazy.nvim.
  2. Enable colorscheme

Expected Behavior

Colors like the screenshots.

Repro

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  {
    "EdenEast/nightfox.nvim",
    lazy = false,
    priority = 1000,
  },

  {
    'nvim-lualine/lualine.nvim',
    config = function ()
      require('lualine').setup()
    end,
  },

}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("dayfox")
EdenEast commented 6 months ago

I am not I understand the issue you are having. From the screenshots you have provided everything looks correct. From what I see you have opened the start of the help with the default vim syntax highlights (not treesitter). As for the status bar that does look like lualine.

A note about the statusline in the screenshots that is not lualine but was my custom feline statusbar (see the note below the list of screenshots)

herrbischoff commented 6 months ago

Regarding the status bar, I seem to have missed that. But given that Lualine is listed as supported and the screenshots containing a very differently colored statusline, it's easy to get confused. If nothing else, that's my issue. The colors for Lualine look entirely out-of-place.

If the colors are as intended, feel free to close this issue.

EdenEast commented 6 months ago

When it says is supported that means that this colorscheme defines the file lua/lualine/themes/<name>.lua where name is the current applied colorscheme found by the variable vim.g.colors_name. If these files were not found then it would just use links to other highlight groups.

There are multiple status lines as lightline is also supported.