search

EdenEast / nightfox.nvim

🦊A highly customizable theme for vim and neovim with support for lsp, treesitter and a variety of plugins.
MIT License
2.86k stars 134 forks source link

feat(extras): Added support for ghostty #395

Closed ethanholz closed 6 months ago

ethanholz commented 6 months ago

Adds support for @mitchellh's Ghostty terminal emulator.

EdenEast commented 6 months ago

Since the ghosttly terminal is still close source and not released I cannot confirm that these are correct. Do you have access to the beta and can confirm that these are correct?

ethanholz commented 6 months ago

I do have access to the beta and I can confirm that these themes work. Prior to this, I modified the kitty terafox theme (you can find it here: https://github.com/ethanholz/nix-config/blob/main/ghostty/config) and previously carbonfox to work with these.

mitchellh commented 6 months ago

@EdenEast If you're interested, I'd be happy to add you to the beta. Anyone who maintains anything in an ecosystem around terminal emulators (themes included) is an instant invite. No pressure, just wanted to offer. Join the discord and ping me and I'll add you: https://discord.gg/ghostty

EdenEast commented 6 months ago

Thanks for contributing. I looked at the extra generation and did some refactors, as I have not touched it in a while. I tried your Pr in ghostty and tested the changes. I will rebase your pr on the refactor that I did and merge this. Thanks for contributing and thanks @mitchellh for letting me try ghostty. Using it as my full time terminal with no issues. Feel the difference between my old terminal wezterm.

ethanholz commented 6 months ago

Excellent! I appreciate you taking the time to test this, thanks to @mitchellh for providing access to the beta!