search

EdenEast / nightfox.nvim

🦊A highly customizable theme for vim and neovim with support for lsp, treesitter and a variety of plugins.
MIT License
2.86k stars 134 forks source link

bug: non-yellow color for carbonfox alacritty configuration file #402

Closed halshar closed 5 months ago

halshar commented 5 months ago

Neovim version (nvim -v)

NVIM v0.10.0-dev-2050+gc4acbb87b

Operating system/version

Fedora Linux - 39

Describe the bug

The yellow hex code for the carbonfox alacritty config is not exactly yellow, for the normal, bright, and the dim sections the hex code for yellow color is as follows

[colors.normal]
yellow = "#08bdba"

[colors.bright]
yellow = "#2dc7c4"

[colors.dim]
yellow = "#07a19e"

the above hex codes are not exactly yellow but more on the blue side as seen below image

have checked that the yellow hex codes for other themes for alacritty config are either shade of yellow or orange

with the above config the yellow color looks like blue(checked with the neofetch color palette), if this is the expected hex code then please close the issue

Steps To Reproduce

  1. replace the current/default alacritty.toml code with carbonfox's config

Expected Behavior

the yellow color should be yellow

Repro

No response

EdenEast commented 5 months ago

This is expected, carbonfox was a port of oxocarbon when it was originally written in rust. This was ported so that others did not have to have rust installed to use the colorscheme.

You can see that in the screenshots that there is no yellow ex:

carbonfox nightfox

The colors come from the palette file:

https://github.com/EdenEast/nightfox.nvim/blob/1e650316680a777fb50e4ab35d82ecf32da485b8/lua/nightfox/palette/carbonfox.lua#L14-L23

image