search

Edenhofer / Minimalism-Gnome-Shell

Minimalism Gnome Shell Extensions
28 stars 3 forks source link

Fixed hide-workspace plugin error: variable not found #5

Closed robier closed 7 years ago

robier commented 7 years ago

After installing Ubuntu 17.04 I noticed that plugin hide-workspace sometimes work, and sometimes don't. I did small investigation and in my syslog I noticed error:

Extension "hide-workspace@xenatt.github.com" had error:
ReferenceError: tmp_getAlwaysZoomOut is not defined

So after finding plugin source code I made some adjustments as you can see in this pull request, also while doing that I added some missing semicolons :)

Edenhofer commented 7 years ago

Thanks a lot for you work. I merged your changes with a slightly different commit message. For example I try to write the message using a different time and from now on will prefix a commit with the extension's name it changes. Admittedly I handled it differently in the past but I try to be more attentive. I even feel a little embarrassed having merged 6530e25 considering it did not change a thing because of the scope of a variable in JavaScript. Either way thanks again and have a great week!

robier commented 7 years ago

No problem, have fun!