search

EdgarAllen / SuperSoundMuffler

MIT License
2 stars 10 forks source link

Sound Muffler White/Blacklist issue #2

Open Darkosto opened 5 years ago

Darkosto commented 5 years ago

Hello!

Just recently, I've noticed SSM's whitelist/blacklist feature has not been working correctly. Within the range, any sounds are muted even when selecting a specific sound. The sound muffler persists even after the block is broken and a full client restart is needed to hear sounds within the range.

I'm not totally sure if this is due to a forge update or another mod interaction? I can test further if needed. I livestream almost daily, so I can do any testing live if you would like.

Forge: 2808 SSM: 1.0.2.9 MC: 1.12.2

Thank you! Darkosto

EdgarAllen commented 5 years ago

I believe I fixed the issue. It appears that some tiles entities were not getting invalidated and garbage collected when you relogged into a world without fully restarting the client. This caused some mufflers to appear twice in the cache and would continue to muffle even after you break the muffler block. Which I think is the issue you were having. If not, let me know.

Darkosto commented 5 years ago

Just tested this out and with the new update: 1.0.2.10. Looks to be the same thing happening as before.