search

EdgarAllen / SuperSoundMuffler

MIT License
2 stars 10 forks source link

Unable to detect sound from Advanced Rocketry #3

Open jaxmacky opened 5 years ago

jaxmacky commented 5 years ago

Sound Muffler is unable to detect Advanced Rocketry's Chemical Reactor.

AdvancedRocketry-1.12.2-1.5.0-132-universal supersoundmuffler-1.12.2-1.0.2.10

dmodoomsirius commented 5 years ago

Zmaster , [11.03.19 02:51] it uses zmaster587.libVulpes.client.RepeatingSound which extends net.minecraft.client.audio.MovingSound

Zmaster , [11.03.19 02:51] the difference being this

@Override
  public void update() {
    if(tile.isInvalid())
      this.donePlaying = true;
    if(toggle != null)
      this.volume = toggle.isRunning() ? 1f : 0f;
  }

Zmaster , [11.03.19 02:53] it still uses vanilla to actually play the sound, the only difference being it'll stop it if the machine is not running by changing the volume to 0

Zmaster , [11.03.19 02:53] if they're using ASM it might fuck up because it's a different class