EdgeLab-FHDO / Edge-Diagnostic-Platform

MIT License
0 stars 2 forks source link

Match making scorebase pull request #68

Closed zero212 closed 3 years ago

zero212 commented 3 years ago
  1. Some comments I only write once, but they may apply to more than one place in the code. Always check all occurances.
  2. Logging should be part of the master input in match making, that is already implemented in the function read(). Move all logging instances to write to the variable command instead. You may need to use a list of commands instead of a single string value.
  3. All commented code must either be removed or explained.
  4. All TODO's must either be removed or mentioned in the issue as future work.
  5. Changes in spaces and tabs should be removed (unless they are corrections).
  6. Unit testing.

1 -> Done 2 -> not done, kinda reluctant to try that tbh, gonna skip for now, will revise this on holiday season :)) 3 -> Done 4 -> Pretty much done, TODO checked twice, only necessary and important TODOs are left 5 -> Already discuss about this :)) 6 -> Done by 9435d99 , 8586472

@alyhasansakr should be okay for a pull request now