EdgePi-Cloud / edgepi-python-sdk

Python SDK to control EdgePi, an industrial PC/PLC/IoT device powered by Raspberry Pi CM4
MIT License
6 stars 3 forks source link

removing hw test and matching version #433

Closed sjpark608 closed 2 months ago

github-actions[bot] commented 2 months ago

Code Coverage

Package Line Rate Branch Rate Health
adc 92% 87%
calibration 100% 100%
dac 100% 97%
digital_input 100% 91%
digital_output 98% 95%
eeprom 83% 63%
eeprom.protobuf_assets.eeprom_data_classes 97% 52%
eeprom.protobuf_assets.generated_pb2 77% 50%
gpio 98% 94%
led 0% 0%
peripherals 69% 23%
pwm 96% 95%
reg_helper 97% 85%
relay 100% 100%
tc 98% 98%
utilities 100% 100%
Summary 92% (3176 / 3457) 80% (680 / 845)
farzadpanahi commented 2 months ago

@sjpark608 why did we remove hw tests?

sjpark608 commented 2 months ago

@sjpark608 why did we remove hw tests?

This was due to the delay in releasing to TestPyPI. When I was merging dev to staging branch, I had few issues.

  1. changed dependency mentioned in #428
  2. then #432, where failed job still bumped the version and publish
  3. 434 after resolving above 2 issues, The hardware tests were passing but it was using older version published on TestPyPi. The webpage still showed the latest package version, but what it actually installed was previous version.

    For this PR, it was installing 1.2.17 instead of 1.2.20

I end up manually executing the HW test by installing the latest package using the github handle

farzadpanahi commented 2 months ago

@sjpark608 why did we remove hw tests?

This was due to the delay in releasing to TestPyPI. When I was merging dev to staging branch, I had few issues.

  1. changed dependency mentioned in Github build-and-publish-TestPypi action fails #428
  2. then Staging Action fails on version mismatch between staging and dev #432, where failed job still bumped the version and publish
  3. Minor Issue installing from TestPyPI during workflow #434 after resolving above 2 issues, The hardware tests were passing but it was using older version published on TestPyPi. The webpage still showed the latest package version, but what it actually installed was previous version. For this PR, it was installing 1.2.17 instead of 1.2.20

I end up manually executing the HW test by installing the latest package using the github handle

let's discuss this later this week and try to come up with a solution that runs the hw tests automatically.