search

EdgeTX / buddy

The next generation tool for EdgeTX. A cross platform app, with browser compatibility.
https://buddy.edgetx.org
MIT License
37 stars 19 forks source link

fix: handle subfolders in firmware bundle #33

Closed freshollie closed 2 years ago

freshollie commented 2 years ago

Fixes #32

codecov-commenter commented 2 years ago

Codecov Report

Merging #33 (faebfc5) into main (11ef30e) will increase coverage by 0.08%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   52.52%   52.61%   +0.08%     
==========================================
  Files          80       80              
  Lines        7807     7809       +2     
  Branches      629      630       +1     
==========================================
+ Hits         4101     4109       +8     
+ Misses       3697     3691       -6     
  Partials        9        9
Impacted Files Coverage Δ
src/shared/backend/services/firmwareStore.ts 53.71% <66.66%> (+0.53%) :arrow_up:
src/shared/backend/graph/firmware/index.ts 57.18% <0.00%> (+1.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11ef30e...faebfc5. Read the comment docs.

pfeerick commented 2 years ago

I'm assuming here I should be able to use the 'Preview' link from the CI comment and it should just work:tm:? If so, unfortunately something went wrong, as it's not to list the contents of a release now... whether normal or a pre-release/nightly... shortly after loading the page it gives

image

freshollie commented 2 years ago

Preview link is unable to download firmware through the proxy due to the restrictive referrer settings