EdgeTX / buddy

The next generation tool for EdgeTX. A cross platform app, with browser compatibility.
https://buddy.edgetx.org
MIT License
37 stars 19 forks source link

Cloudbuild integration (WIP) #49

Closed riwanou closed 1 year ago

riwanou commented 1 year ago

Cloudbuild integration

Add integration for cloudbuild, which build firmware on demand based on more options than existing github releases.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 45.12% and project coverage change: -1.35% :warning:

Comparison is base (1fdddd4) 52.92% compared to head (62e9c52) 51.57%.

:exclamation: Current head 62e9c52 differs from pull request most recent head cf3ba83. Consider uploading reports for the commit cf3ba83 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================== - Coverage 52.92% 51.57% -1.35% ========================================== Files 82 89 +7 Lines 7862 8841 +979 Branches 628 656 +28 ========================================== + Hits 4161 4560 +399 - Misses 3693 4272 +579 - Partials 8 9 +1 ``` | [Files Changed](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/renderer/components/CloudVersionTargetForm.tsx](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JlbmRlcmVyL2NvbXBvbmVudHMvQ2xvdWRWZXJzaW9uVGFyZ2V0Rm9ybS50c3g=) | `18.61% <18.61%> (ø)` | | | [...rer/components/firmware/DownloadFirmwareButton.tsx](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JlbmRlcmVyL2NvbXBvbmVudHMvZmlybXdhcmUvRG93bmxvYWRGaXJtd2FyZUJ1dHRvbi50c3g=) | `56.56% <22.03%> (-12.96%)` | :arrow_down: | | [...ash/steps/firmware/CloudFirmwareReleasesPicker.tsx](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JlbmRlcmVyL3BhZ2VzL2ZsYXNoL3N0ZXBzL2Zpcm13YXJlL0Nsb3VkRmlybXdhcmVSZWxlYXNlc1BpY2tlci50c3g=) | `28.49% <28.49%> (ø)` | | | [src/renderer/hooks/useFlags.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JlbmRlcmVyL2hvb2tzL3VzZUZsYWdzLnRz) | `52.63% <52.63%> (ø)` | | | [src/shared/backend/graph/firmware/github.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoYXJlZC9iYWNrZW5kL2dyYXBoL2Zpcm13YXJlL2dpdGh1Yi50cw==) | `57.94% <57.94%> (ø)` | | | [src/shared/backend/graph/firmware/cloudbuild.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoYXJlZC9iYWNrZW5kL2dyYXBoL2Zpcm13YXJlL2Nsb3VkYnVpbGQudHM=) | `58.79% <58.79%> (ø)` | | | [src/shared/backend/services/cloudbuild.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoYXJlZC9iYWNrZW5kL3NlcnZpY2VzL2Nsb3VkYnVpbGQudHM=) | `64.40% <64.40%> (ø)` | | | [...nderer/pages/flash/steps/FirmwareSelectionStep.tsx](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JlbmRlcmVyL3BhZ2VzL2ZsYXNoL3N0ZXBzL0Zpcm13YXJlU2VsZWN0aW9uU3RlcC50c3g=) | `85.94% <74.41%> (-2.63%)` | :arrow_down: | | [src/shared/backend/graph/firmware/local.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoYXJlZC9iYWNrZW5kL2dyYXBoL2Zpcm13YXJlL2xvY2FsLnRz) | `75.80% <75.80%> (ø)` | | | [src/shared/backend/context.ts](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoYXJlZC9iYWNrZW5kL2NvbnRleHQudHM=) | `94.87% <100.00%> (+0.42%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/EdgeTX/buddy/pull/49?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freshollie commented 1 year ago

Probably need to do something to get the cloudflare pages working? I'm not sure I understand the error

freshollie commented 1 year ago

e2es are failing because the build they are looking for is too far down the list to click. I can look into this at some point but you can ignore for now as long as you are happy everything functions

freshollie commented 1 year ago

Also consider writing some units tests for your resolvers, and maybe some unit tests for the page. There are lots of examples in the codebase of these. If you can't figure it out, don't worry. For the resolver tests you can use nock to record responses to that they work even if the server is offline, there are examples of this.

riwanou commented 1 year ago

Moved to https://github.com/EdgeTX/buddy/pull/50