Closed riwanou closed 1 year ago
Patch coverage: 45.12%
and project coverage change: -1.35%
:warning:
Comparison is base (
1fdddd4
) 52.92% compared to head (62e9c52
) 51.57%.:exclamation: Current head 62e9c52 differs from pull request most recent head cf3ba83. Consider uploading reports for the commit cf3ba83 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Probably need to do something to get the cloudflare pages working? I'm not sure I understand the error
e2es are failing because the build they are looking for is too far down the list to click. I can look into this at some point but you can ignore for now as long as you are happy everything functions
Also consider writing some units tests for your resolvers, and maybe some unit tests for the page. There are lots of examples in the codebase of these. If you can't figure it out, don't worry. For the resolver tests you can use nock to record responses to that they work even if the server is offline, there are examples of this.
Cloudbuild integration
Add integration for cloudbuild, which build firmware on demand based on more options than existing github releases.