Closed raphaelcoeffic closed 4 months ago
@freshollie the thing that puzzles me the most are the 302 exceptions. I had to update to nock@14-beta
, as it has support for fetch
, which is now what ky
uses on Node 18+. AFAIK, fetch
is supposed to follow 302 automatically, which also happens in browser, but not in the tests. I removed ky-universal
, as it is not needed anymore (ky
uses native fetch
on Node 18+). Not sure what else could be involved.
EDIT: it seems that just removing the redirects and pretending they never happened just works. It is to be noted thought that nock@14-beta
still has no support for recording.
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://fd72a81e.buddy-7a6.pages.dev ✅ Storybook: https://fd72a81e.buddy-7a6.pages.dev/storybook
@raphaelcoeffic good job getting the tests working! Glad you found the issue was in the fixtures! 🤞 on CI passing
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://98dd1bec.buddy-7a6.pages.dev ✅ Storybook: https://98dd1bec.buddy-7a6.pages.dev/storybook
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://721df49b.buddy-7a6.pages.dev ✅ Storybook: https://721df49b.buddy-7a6.pages.dev/storybook
@freshollie it's ready for your review at your earliest convenience.
Regarding next steps, I think we should probably then start updating the rest of the stack (React, components, etc). Then we could probably start tackling new features (SD card, Cloudbuild FW download, etc).
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://74b91682.buddy-7a6.pages.dev ✅ Storybook: https://74b91682.buddy-7a6.pages.dev/storybook
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://75a96a02.buddy-7a6.pages.dev ✅ Storybook: https://75a96a02.buddy-7a6.pages.dev/storybook
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://edcd51f0.buddy-7a6.pages.dev ✅ Storybook: https://edcd51f0.buddy-7a6.pages.dev/storybook
EdgeTX Buddy has been automatically deployed to Cloudflare. ✅ Preview: https://319267c4.buddy-7a6.pages.dev ✅ Storybook: https://319267c4.buddy-7a6.pages.dev/storybook
Summary of changes:
20.x
.vitest
to latest.ky
to latest (and removedky-universal
, as Node 18+ provides native support forfetch
API).nock
to14.0.0-beta5
to add support forfetch
API (please note that recording is NOT supported).electron
andelectron-builder
to latest (electron-rebuild
removed on the way).Fixes #60.