search

EdgeTX / edgetx-sdcard-sounds

Sound packs for EdgeTX
GNU General Public License v2.0
82 stars 48 forks source link

PT sound revision #74

Closed zandorsp closed 11 months ago

zandorsp commented 11 months ago

A revision and remake of the PT file to "sync-it" to english one

zandorsp commented 11 months ago

This gap on id between System sounds and (user,normal?) sounds is a problem? https://github.com/zandorsp/edgetx-sdcard-sounds/blob/main/voices/pt-PT.csv?plain=1#L196-L197

zandorsp commented 11 months ago

closed for #76

pfeerick commented 11 months ago

This gap on id between System sounds and (user,normal?) sounds is a problem? https://github.com/zandorsp/edgetx-sdcard-sounds/blob/main/voices/pt-PT.csv?plain=1#L196-L197

Not sure what you mean there... there's no gap there? The first number is just a unique row number... which I'm hoping we can get synced up across all the translations so that, for example, row 202 is the same for every language pack, and then there is a single file to update, meaning all languages get equal treatment. If we don't get there (which we may not, as needs a maintainer for each language to get it moved over), so it be. My main concern before was simply the missing system sounds that were going to get deleted.

If there was a row gap in the middle, that shouldn't matter.

edit: ok, I see the gap in your revised PR... as long as the generator script doesn't fail, all good... and if it does, it means I need to fix it 🤭