search

EdgeTX / edgetx-sdcard-sounds

Sound packs for EdgeTX
GNU General Public License v2.0
82 stars 48 forks source link

fix: Remove 'v' prefix from release VERSION #93

Closed gonzalo-bulnes closed 6 months ago

gonzalo-bulnes commented 6 months ago

Fixes #73

Details in the commit message.

gonzalo-bulnes commented 6 months ago

@pfeerick I left a question in the issue to make sure I understand it correctly.

And I opened this as a draft because I'm not sure how to test it**, but I guess maybe you can.

** Well, VERSION="v1.2.4v"; echo ${VERSION#v} works as expected but I haven't tested it in the context of the workflow.

pfeerick commented 6 months ago

That should do the trick... GITHUB_REF is supposed to be formatted like refs/tags/<tag_name>, so v2.9.0 should equate to GITHUB_REF=refs/tags/v2.9.0. Only real way to test this will probably be to actually use it, and see if it works or breaks (and then send to purgatory along with all the other badly behaved code).

gonzalo-bulnes commented 6 months ago

Only real way to test this will probably be to actually use it, and see if it works or breaks (and then send to purgatory along with all the other badly behaved code).

Not a bad plan IMHO. 👍 I'm marking it as ready for review (not draft).