edgetx.sdcard.version contains wrong version reference

EdgeTX / edgetx-sdcard

SD Card contents and images for EdgeTX

129 stars 41 forks source link

edgetx.sdcard.version contains wrong version reference #102

Closed ror1948 closed 1 year ago

ror1948 commented 1 year ago

Is there an existing issue for this problem?

[X] I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Other (Please specify below)

Current Behavior

SDCARD contents with text file edgetx.sdcard.version in the root contains 2.8 instead of 2.8.1

Expected Behavior

no effect noticed. just incorrect documentation.

Steps To Reproduce

just open file edgetx.sdcard.version and look at version number stated

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

2.8.1

raphaelcoeffic commented 1 year ago

This file has been basically obsoleted, so I guess we should just remove it.

pfeerick commented 1 year ago

Also, please keep in mind it IS actually correct - did you install a (non-existent) 2.8.1 sd pack? ;) We could remove it as the firmware isn't dependent on it, but I think it still serves a purpose as to at least "suggesting" what version of the pack you have installed (assuming it does get replaced on updates, and doesn't get manually edited, of course).

ror1948 commented 1 year ago

No Why does it matter? Thanks

pfeerick commented 1 year ago

Um... because edgetx.sdcard.version describes the version of the sd card pack, not the version of edgetx?

offer-shmuely commented 1 year ago

As a suggestion, it is good enough they it is. It should not be patch similar to the version of the actual firmware. So the issue can be closed