EdgeTX / edgetx-sdcard

SD Card contents and images for EdgeTX
125 stars 41 forks source link

Plane Wizard disregards Safety Switch setting #130

Closed daveEccleston closed 8 months ago

daveEccleston commented 9 months ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Other (Please specify below)

Current Behavior

When going through the Plane wizard, I select "NO" for the safety switch setting

When the model is created it makes a safety switch regardless

Expected Behavior

I expect if I choose "No" for safety switch, that none be created

Steps To Reproduce

Start the wizard Choose Plane On the Motor Settings page, change Safety Switch to "No" Accept all defaults for all other choices and create the model Go to the Special Functions page, observe that an override switch was created

Version

2.9.3

Transmitter

RadioMaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

pfeerick commented 9 months ago

This relates to #129, in that configuration parameters are in the template, rather than being created as needed by the wizard lua.

offer-shmuely commented 9 months ago

I will check

pfeerick commented 9 months ago

Much appreciated :)

offer-shmuely commented 9 months ago

see PR #131

offer-shmuely commented 9 months ago

I can see the same bug on the glider as well