search

EdgeTX / edgetx-sdcard

SD Card contents and images for EdgeTX
130 stars 42 forks source link

Heli wizard added #92

Closed jrwieland closed 1 year ago

jrwieland commented 1 year ago

c480x272

bw128x64

bw212x64

offer-shmuely commented 1 year ago

Hi it is a very nice one :-)

some things to think about.

  1. do we really need to support the FLY-BAR? does it still popular? around me, all have flight-controller (aka: flybarless)
  2. the channel5 maybe better called "T.Gain" instead of GYRO, since on modern flight-controller you can have cyclic-gain as well
  3. the default of throttle can be "flat" for all 3 mode? since most friends use governor anyway, so you do not need a graph, but just weight=0 + offset=70%
  4. announce for bank0/bank1/back2 will be nice
  5. I put the T.Gain on trim T5, it is very useful, (including the appropriate voices)
  6. It will be nice to name the channel on the output page

Great work!

pfeerick commented 1 year ago

do we really need to support the FLY-BAR? does it still popular? around me, all have flight-controller (aka: flybarless)

Most definitely. There are still a lot of heli flyers with older helis. Plus, there's the whole choice thing ;)

I put the T.Gain on trim T5

Might just have to be wary of transmitters that don't have a T5

I'll be back to look at this properly in a few days... please feel free to ping me if that is longer than a week ;)

jrwieland commented 1 year ago

@offer-shmuely
Thank you for the feedback, I apologize for the delay in responding I had a critical project for work that was taking all of my attention/energy.

One thing to consider with all of the wizards. They are designed to be used by new users to EdgeTX and load a basic setup for that particular model type, and get them in the air. Most experienced users will utilize their own template or copy an existing model as a starting point rather than starting from scratch using a wizard.

I thought about making the initial selection for the curves" FLAT" for all ide ups (since that is what i run on all my FM's) and the modern ESC's spool much slower than the old word counterparts. as Peter said it comes down to choice. Do I put this one or that one first. Do I impose my preferences or make them decide by the order of the curves.

Utilizing "T.Gain" instead of GYRO is a good idea, I used gyro due to its common use with other radio systems.

Using the term "banks" tells me you use a "V" or kbar. Having announcements pre-programmed takes away from the "Customizable aspect". We all came to open source due to the fact that we could make it "Your radio , your way". The more that is added to the wizards makes it more and more like futaba, spectrum etc. Doing the simple tasks of setting announcements/warnings when something is changed is the initial steps to fully customizing it IMHO.

Adding the name to the outputs is another good idea. Thank you. I'll make those changes this weekend

offer-shmuely commented 1 year ago

Thanks for good work I am using ikon2 & spirit2 and planning to give rotorflight a chance sometime

jrwieland commented 1 year ago

@pfeerick for uniformity should I add output names to the other wizards?