search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.6k stars 339 forks source link

Jumper T-Lite contrast bug #1031

Closed NiklasVoigt closed 2 years ago

NiklasVoigt commented 2 years ago

Describe the bug OpenTX and EdgeTX both have the same Bug. In the Bootloader and when starting the Radio the contrast of the display is very low. After showing the bootlogo the contrast is good. In Bootloader the contrast is always very low.

To Reproduce Go to Bootloader. Start the Radio.

Expected behavior Normal contrast as after bootlogo.

Screenshots bootloader_contrast startup_contrast good_contrast

General information

pfeerick commented 2 years ago

I'm glad it's not me... I've always thought the T-Lite display (and also the TX12) was not the best at times. i.e. the boot screen on the TX12 gets a bit darker during the splash delay, and the bootloader screen on the T-Lite has always been dim - it's as if it doesn't go fully black when it should.

erstec commented 2 years ago

@NiklasVoigt can you test it on real T-Lite if I provide you binary?

erstec commented 2 years ago

@NiklasVoigt edgetx-2.5.0-bl_contrast.bin.zip Provided Binary is for Jumper T-Lite. I was tested same code on QX7 and X-Lite and it seems to work ok (was tried different contrast settings). If it solves your "problem" - I will make PR for all Taranis-based (B/W, small screen) radios.

pfeerick commented 2 years ago

This seems noticeably darker on my T-Lite. Is there something also going on just after the four dots / segments animation... as looking at it a bit more closely now, it seems like the dots are probably nomal darkness, and then just as the last one lights up, before the logo shows, the contrast seems to drop for the logo... and be normal again after that. Just thought I'd mention it incase it was a similar problem/fix needed.

erstec commented 2 years ago

@pfeerick Ok, I see. Please try again, if you can.

Edit: File removed due to incorrect compiling flags

pfeerick commented 2 years ago

So, this does appear to work, but causes another problem... the T-Lite will not boot :-P

You may be then scratching your head and asking how this fixes the problem if I can't turn the radio on... well... it won't boot if pressing the power button... backlight stays off, blue LED, nothing on the screen. But if I instead enter the bootloader, and exit via that, the contrast seems ok...

Is it likely the change you made caused this, or should I ping Raphael to check if there are linker issues affecting the T-Lite target also (we just had one that b0rked the NV14 builds - was just a ticking time bomb waiting to go off).

NiklasVoigt commented 2 years ago

If it won't boot now I won't flash the test files haha. The t lite is my daily driver.. I think @pfeerick has become our experiment animal haha

erstec commented 2 years ago

If it won't boot now I won't flash the test files haha. The t lite is my daily driver.. I think @pfeerick has become our experiment animal haha

You can: start to bootloader, select Exit and it will boot

And please don't use last provided binary, I found issue in it and will provide fixed version shortly

EDIT: Oh, I was mesreading, I read that you already 'bricked' :) just ignore this message then :)

And please use https://github.com/EdgeTX/edgetx/files/7553102/edgetx-2.5.0-bl_contrast3.bin.zip It is tested, at least as much as I can with current B/W radios I have.

erstec commented 2 years ago

So, this does appear to work, but causes another problem... the T-Lite will not boot :-P

You may be then scratching your head and asking how this fixes the problem if I can't turn the radio on... well... it won't boot if pressing the power button... backlight stays off, blue LED, nothing on the screen. But if I instead enter the bootloader, and exit via that, the contrast seems ok...

Is it likely the change you made caused this, or should I ping Raphael to check if there are linker issues affecting the T-Lite target also (we just had one that b0rked the NV14 builds - was just a ticking time bomb waiting to go off).

I found what is wrong, it my fault, wrong compiler definitions... really sorry... fixed already and "last" try to solve mentioned problem FW placed below. Test it if you can. Thank you for support!

If it will not solve problem - at least we will have good contrast in BootLoader :)

erstec commented 2 years ago

@NiklasVoigt @pfeerick Please use this binary. Testes on both my remotes, no 'freeze' issue anymore. It whould be very informative to know if it solves 'after dots' problem also. edgetx-2.5.0-bl_contrast3.bin.zip

pfeerick commented 2 years ago

really sorry... fixed already

Don't be... that's what testers are for ;)

Anyway, I think you are on to a winner with contrast3... bootloader looks fine, main firmware seems fine... no noticeable 'lightening' of the dots or splash screen. Oh, and it does boot normally! 😁