search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.64k stars 345 forks source link

LUA widgets: EM on power down #104

Closed JimB40 closed 3 years ago

JimB40 commented 3 years ago

Goes to EM every single time. Same with previous builds. https://youtu.be/D9g3GjSMScE

General information EgdeTX version f58317f RM TX16S

rotorman commented 3 years ago

This seems to happen when at least one LUA widget is active on any page. Can you please test if the EM comes as well, when none of your pages have LUA widgets included? On mine, then there is no EM screen on shut-down anymore.

JimB40 commented 3 years ago

Tested. Removed all LUA widgets even those on topbar. Still EM every time *** Update. Sorry left one :) You are right. EM happens when there is a full-screen view with telemetry script. Other layouts don't seem to affect it

rotorman commented 3 years ago

I tested this on RM TX16S with f5240bdf and hw-debugger attached. If at least one LUA widget is selected on a page, I see HardFault / STKALIGN on shutdown (even with the stack alignment fix PR #115 ). Here screenshot of Segger Ozone with the error and call stack: Shutdown_HardFault_LUA

rotorman commented 3 years ago

PR #113 solves the issue for me. @JimB40 how does it work for you? If positively, we could close this issue?

JimB40 commented 3 years ago

Little confused from which version of FW should get to test. Downloaded today tx16s-a972353.bin from artifact but file for tx16s has 134MB, so I was little hesistant to write it :)

rotorman commented 3 years ago

@JimB40 Try under Artifacts here: https://github.com/EdgeTX/edgetx/actions/runs/888034651

JimB40 commented 3 years ago

Seems that is solved

https://youtu.be/1wN3cvuvAnk

Chapeau bas 😀

rotorman commented 3 years ago

Awesome @JimB40 and thank you for the video. Can we close the issue?

JimB40 commented 3 years ago

Think so. I'll give more intensive test run in afternoon. Will comment here if I encouter any problems.