search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

Not so much a bug as a switch test missed #2183

Open MervDale opened 2 years ago

MervDale commented 2 years ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

In the switch test sequence , Radio Settings, Hardware, Switches.... all switches are tested but the P 1 to 6 Butttons are not,

Expected Behavior

Should be included

Steps To Reproduce

Radio Settings, Hardware, Switches

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S

Anything else?

Nightlies I'm not sure if this has been mentioned here but I remember hearing from another user.

pfeerick commented 2 years ago

I'm not sure if this will happen since the 1-6 buttons are actually an analog input like the pots and sliders which is treated like a set of buttons. So is tested on the analogs page (06 for the TX16S). It would only make sense to do so if we are able to make it so you don't need to also calibrate it along with the other analogs.

MervDale commented 2 years ago

Yes I guess you are right there, they aren't quite so obvious in the analogs showing up as only one entry but yes you do need to calibrate them and they are not really switches which you don't have to calibrate.

gagarinlg commented 2 years ago

It should be possible to use them without calibration. There can't be much different in the voltage the 6-POS MCU generates between the different radios.

raphaelcoeffic commented 2 years ago

It should be possible to use them without calibration. There can't be much different in the voltage the 6-POS MCU generates between the different radios.

This is something we should really consider. Calibrating these 6POS is really a pain.

rdeanchurch commented 1 year ago

Not to mention that it is impossible to 'Center' an even number of switches. Since they are discrete analog values they should not be allowed where a true or false is expected. For instance we can use 6P-1, 6P-2.. to select Flight Modes.
But changing the chicken feet does not change Flight Modes. Also presently I can't find how to put any 6P, into a widget so it's value can be displayed.

Either treat it like an analog or as 6 true or false values, please!.

Well,I was going to attach .etx to show this, but .etx is not allowed attachment type.

Tested in 2.8.4 EdgeTxCompanion only. ThrSafe.pdf ThrSafe-RM-TX16S-2023July16-Rdy03.zip