search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

Unexpected wrap behaviour in Mixers menu when using scrollwheel #2385

Open RC-SOAR opened 2 years ago

RC-SOAR commented 2 years ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

In the mixers menu, when using the scrollwheel, the mixer list wraps to be beginning when the end is reached. The 'Show mixer monitors' option, and '+' lines wrap as well.

Expected Behavior

Wrap behavour with scrollwheel should be consistent with touch (which works correctly).

Steps To Reproduce

Open the Mixers menu and - using the scrollwheel - scroll past the end of the mixer list.

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S

Anything else?

TX16S / 2.8.0 rc-1

RC-SOAR commented 2 years ago

Just looked at the SF and Inputs menus, and it seems that the wrapping behaviour when using the scrollwheel is the same in all menus, so I guess this is the convention that has been adopted (and it's the same in Ethos).

So the problem really is that the 'Show mixers monitors' and '+' options scroll and wrap as well. I think these would be better as static elements.

raphaelcoeffic commented 2 years ago

So the problem really is that the 'Show mixers monitors' and '+' options scroll and wrap as well. I think these would be better as static elements.

What do you mean with "static elements"? If you mean to have the mixer channels/lines in a separate scroll-box, and these 2 always on screen, I'm afraid this going to cost quite some space, thus leaving much less for actually displaying the mixer channels/lines (which some people have been complaining about).

RC-SOAR commented 2 years ago

By 'static', I mean it shouldn't scroll. I appreciate that an extra row would not be practical, but there appearst to be space on the title bar for extra info. This could also be used for the mixer monitor display:

screen-2022-09-28-093758

gagarinlg commented 2 years ago

But then you only have one mixer monitor nad not monitors for every mixer that fits onto the screen

The +-Button in the title bar to add a new channel might work well

RC-SOAR commented 2 years ago

But then you only have one mixer monitor nad not monitors for every mixer that fits onto the screen

If want to see all the mixer values, a single press on MDL takes you to the Outputs,

It's not a new idea, OpenTX displays the value of just one channel:

screenshot_tx16s_22-09-28_12-02-04