EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

Improvements to Mixers menu UI #2400

Open RC-SOAR opened 2 years ago

RC-SOAR commented 2 years ago

In 2.8.0 RC1/TX16S, channels which don't have mixers are hidden. This leads to two issues:

  1. There are two entirely different methods of input for new mixers, depending on whether the channel is displayed/hidden:

I find this really confusing.

  1. The second problem: it's not possible to see the 'holes' in the channel list. For the complete picture, it should be possible to see all channels.

Describe the solution you'd like

I would like to revert to the OpenTX display format, where all channels are displayed, whether used or not. Then only {insert before/after} would be needed (the '+' option could be removed).

Also, I think it would be more useful to display channels in the format CHnn:[name] - channel numbers are useful to see, since they can be the source of a new mix.

Ultimately, there should be no distinction between channels with and without mixes, since internally they all contribute to the outputs.

Describe alternatives you've considered

Another option would be to just have just a single method of adding mixers, via an enhanced '+' option.

Pressing on '+' would open a submenu displaying a list of all locations to place the new mix.

However this would IMO would only work well if the '+' option was permanently displayed (currently, to access the '+' option, you have to scroll down to the bottom of the channel list).

Additional context

TX16S / 2.8.0 RC-1

gagarinlg commented 2 years ago

Also, I think it would be more useful to display channels in the format CHnn:[name] - channel numbers are useful to see, since they can be the source of a new mix.

I agree, the number should also be shown, but real estate is limited, so nn:[name] should be enough.

Ultimately, there should be no distinction between channels with and without mixes, since internally they all contribute to the outputs.

Without a mixer there is no data source for the output, so it just transmits its center value all the time. To keep the UI clean I think it is totally reasonable to not display channels with no mixer.

However this would IMO would only work well if the '+' option was permanently displayed (currently, to access the '+' option, you have to scroll down to the bottom of the channel list).

This is also a reals estate problem. When the + Button is shown all the time, less mixers can be displayed at the same time.

RC-SOAR commented 2 years ago

This is also a reals estate problem. When the + Button is shown all the time, less mixers can be displayed at the same time.

Looking at the 'MIxer' title bar, there appears to be quite a bit of space which is not currently used. Could this not be put to use?

screen-2022-09-28-093758

pfeerick commented 2 years ago

Also need to juggle making stuff big enough for touch, and non-touch users.

gagarinlg commented 1 year ago

@RC-SOAR did you check the current nightlies or 2.8.3? It looks much better now.

RC-SOAR commented 1 year ago

Not yet, but look forward to trying this next week.