search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.56k stars 332 forks source link

Top Bar Widget disappears when you activate internal GPS. #2409

Open RipperGOT opened 1 year ago

RipperGOT commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

When you activate the internal gps and the icon appears next to the battery, the fourth widget disappears.

Expected Behavior

The fourth widget should still appear

Steps To Reproduce

Activate internal GPS

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S

Anything else?

IMG_20220928_220726

In firm simulator

Captura de pantalla 2022-09-28 220618

pfeerick commented 1 year ago

It actually looks like the simulator and radio aren't updating the top bar properly when you turn the GPS option on. If you look closer in top bar settings mode at the size of the top bar widget frames, you'll notice the icon for the GPS actually overlaps the space for the fourth widget - and so the forth widget space is supposed to be turned off because of the collision. When you initially set it on the radio, it will show four top bar widgets, and then when you power cycle it, it will show three. Same would probably happen in the simulator if you changed modes, and it refreshed the top bar properly.

RipperGOT commented 1 year ago

It actually looks like the simulator and radio aren't updating the top bar properly when you turn the GPS option on. If you look closer in top bar settings mode at the size of the top bar widget frames, you'll notice the icon for the GPS actually overlaps the space for the fourth widget - and so the forth widget space is supposed to be turned off because of the collision. When you initially set it on the radio, it will show four top bar widgets, and then when you power cycle it, it will show three. Same would probably happen in the simulator if you changed modes, and it refreshed the top bar properly.

Okay!!! I see what you mean! So, I guess there will be no solution, right?

pfeerick commented 1 year ago

Just a bugfix so that the widget is properly cleared, but other than that, no, not at the moment I don't think. Top bar widgets are a constant size, if only for the sanity of the widget authors. And we can't move that GPS icon over further as there are actually other icons not visible in the "unused" space. If in the future we can make it so the icons/top-bar seconds can be turned on or off ... i.e. "who needs the time" ... well, that would resolve it... but that certainly won't be something added just atm.

RipperGOT commented 1 year ago

OK, thanks mate!!! If you consider it appropriate, change the label to enhancement.

pfeerick commented 1 year ago

Nah, I consider this a bug still, and the last reply material for an enhancement issue - although I may have already done one for that at some point (or not!)

philmoz commented 11 months ago

Is this still an issue now that all top bar elements are widgets (in 2.10)?

RipperGOT commented 11 months ago

Is this still an issue now that all top bar elements are widgets (in 2.10)?

I still have the same problem in 2.9.

3djc commented 11 months ago

The question explicitly mentioned 2.10, not 2.9

pfeerick commented 6 months ago

@RipperGOT would you be able to check this again with a nightly firmware (ensure you backup your RADIO/MODELS folders beforehand if you do)?