EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.58k stars 333 forks source link

R9 ACCESS MOD, R9 FLEX and Bluetooth Mod support on Horus Type radios #260

Closed b14ckyy closed 1 year ago

b14ckyy commented 3 years ago

As we are not able yet to use the OpenTX Companion, we have no option to enable and disable firmware features. So as the title says, the following features are missing:

I really love EdgeTX afte a few minutes of playing around with it but without these it is not yet usable, at least for me.

ucakar commented 2 years ago

Hi DM4DS,

I am looking for externallaccessmod and flexr9m. Can you please upload that option too?

Thanks,

Andrej

DM4DS commented 2 years ago

Hi DM4DS,

I am looking for externallaccessmod and flexr9m. Can you please upload that option too?

Thanks,

Andrej

Uploaded an untested version to my homepage with EXTERNAL and Flex enabled - give me feedback on my discord

Anduurfly commented 2 years ago

Hi DM4DS, I am looking for externallaccessmod and flexr9m. Can you please upload that option too? Thanks, Andrej

Uploaded an untested version to my homepage with EXTERNAL and Flex enabled - give me feedback on my discord

Hi, I am now testing the latest version you created for TX16s (wiring mode was already done). Thanks a lot DM4DS. First i flashed the radio, then i flashed the r9m 2019 access module with the v1.3.0 ACCESS FLEX firmware. Flashed an r9 mini with v1.3.1 ACCESS FLEX firmware. The registration and binding was ok using the 868 protocol. The receiver's led was green. But there were no output on S.Bus I tried with an r9 SX also on ACCESS FLEX firmware. The receiver's led was green. But there were no output on any channel. I re-flashed the whole staff to LBT firmware (i am in EU). Set the external TX to R9ACCESS and EU. The result was the same. Then by some intuity i set the radio to R9ACCESS FCC without changing anything else. The receivers started working immediately. I made some more experiments and found whatever firmware pairs i have on the r9m and the receivers they are binding well, but i get channels outputs only if i set the radio to FCC even all has LBT firmwares. Is that a known issue? Anyone else experienced the same? I suppose if i use LBT formware the communication would be 868mhz whatever i set right? Thanks Andras

DM4DS commented 2 years ago

HiI don't use any R9 hardware. The problems you are writing are not known to me.Have you asked in the EdgeTX discord? Maybe it's a big in the firmware, setting a flag incorrect. Just an idea.Sorry, can't help you.GreetingsSandor-- Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 07.12.21, 13:15 schrieb Anduurfly @.***>:

Hi DM4DS, I am looking for externallaccessmod and flexr9m. Can you please upload that option too? Thanks, Andrej 

Uploaded an untested version to my homepage with EXTERNAL and Flex enabled - give me feedback on my discord

Hi, I am now testing the latest version you created for TX16s (wiring mode was already done). Thanks a lot DM4DS. First i flashed the radio, then i flashed the r9m 2019 access module with the v1.3.0 ACCESS FLEX firmware. Flashed an r9 mini with v1.3.1 ACCESS FLEX firmware. The registration and binding was ok using the 868 protocol. The receiver's led was green. But there were no output on S.Bus I tried with an r9 SX also on ACCESS FLEX firmware. The receiver's led was green. But there were no output on any channel. I re-flashed the whole staff to LBT firmware (i am in EU). Set the external TX to R9ACCESS and EU. The result was the same. Then by some intuity i set the radio to R9ACCESS FCC without changing anything else. The receivers started working immediately. I made some more experiments and found whatever firmware pairs i have on the r9m and the receivers they are binding well, but i get channels outputs only if i set the radio to FCC even all has LBT firmwares. Is that a known issue? Anyone else experienced the same? I suppose if i use LBT formware the communication would be 868mhz whatever i set right? Thanks Andras —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

brainbubblersbest commented 2 years ago

Firmware on tx module need to be flashed to eulbt to use it in eulbt mode

DM4DS @.***> schrieb am Do., 9. Dez. 2021, 14:05:

HiI don't use any R9 hardware. The problems you are writing are not known to me.Have you asked in the EdgeTX discord? Maybe it's a big in the firmware, setting a flag incorrect. Just an idea.Sorry, can't help you.GreetingsSandor-- Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 07.12.21, 13:15 schrieb Anduurfly @.***>:

Hi DM4DS, I am looking for externallaccessmod and flexr9m. Can you please upload that option too? Thanks, Andrej

Uploaded an untested version to my homepage with EXTERNAL and Flex enabled

  • give me feedback on my discord

Hi, I am now testing the latest version you created for TX16s (wiring mode was already done). Thanks a lot DM4DS. First i flashed the radio, then i flashed the r9m 2019 access module with the v1.3.0 ACCESS FLEX firmware. Flashed an r9 mini with v1.3.1 ACCESS FLEX firmware. The registration and binding was ok using the 868 protocol. The receiver's led was green. But there were no output on S.Bus I tried with an r9 SX also on ACCESS FLEX firmware. The receiver's led was green. But there were no output on any channel. I re-flashed the whole staff to LBT firmware (i am in EU). Set the external TX to R9ACCESS and EU. The result was the same. Then by some intuity i set the radio to R9ACCESS FCC without changing anything else. The receivers started working immediately. I made some more experiments and found whatever firmware pairs i have on the r9m and the receivers they are binding well, but i get channels outputs only if i set the radio to FCC even all has LBT firmwares. Is that a known issue? Anyone else experienced the same? I suppose if i use LBT formware the communication would be 868mhz whatever i set right? Thanks Andras —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/260#issuecomment-989834386, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPVHWJLNALAPNESBJLGUVLUQCSQVANCNFSM465K2A4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Anduurfly commented 2 years ago

Hello Sandor, thank you for your feedback and your work on this. I keep investigating.

@brainbubblersbest , did you have experience wit this edgetx version and the r9? If you read my description i wrote that i tried with flex and LBT firmwares too. (flex-flex on the module and the receiver // lbt-lbt on the module and the receiver) But in both cases i get output signal from the receiver if i set the external tx to FCC. This was my problem. I believe if i use the LBT firmware it wil define the frequency itself whatever is set on edgetx. If you have the same hw setup your experience is more than wecome. Thanks

brainbubblersbest commented 2 years ago

I will try eulbt.

András Fejér @.***> schrieb am Do., 9. Dez. 2021, 21:45:

Hello Sandor, thank you for your feedback and your work on this. I keep investigating.

@brainbubblersbest https://github.com/brainbubblersbest , did you have experience wit this edgetx version and the r9? If you read my description i wrote that i tried with flex and LBT firmwares too. (flex-flex on the module and the receiver // lbt-lbt on the module and the receiver) But in both cases i get output signal from the receiver if i set the external tx to FCC. This was my problem. I believe if i use the LBT firmware it wil define the frequency itself whatever is set on edgetx. If you have the same hw setup your experience is more than wecome. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/260#issuecomment-990236305, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPVHWIJINGKX4JN6FEQXEDUQEIP5ANCNFSM465K2A4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Anduurfly commented 2 years ago

I will try eulbt. András Fejér @.***> schrieb am Do., 9. Dez. 2021, 21:45:

Thanks

jpmarotta commented 2 years ago

I can confirm that this issue also occurs on a mod'd TX16S which previously worked flawlessly on OTX. Same symptoms as above: able to "register", unable to bind.

Tested with 2019 R9M on FCC and FLEX firmware.

The following RXs were included in the testing in both FCC and FLEX:

Here's my build if it's useful: edgetx-v2.5_tx16s_lua-ppmus-mode2-R9M-ACCESS-noheli_release.bin.zip

b14ckyy commented 2 years ago

I can confirm that this issue also occurs on a mod'd TX16S which previously worked flawlessly on OTX. Same symptoms as above: able to "register", unable to bind.

Tested with 2019 R9M on FCC and FLEX firmware.

The following RXs were included in the testing in both FCC and FLEX:

  • R9MX OTA
  • R9 Slim+ OTA
  • R9 STAB

Here's my build if it's useful: edgetx-v2.5_tx16s_lua-ppmus-mode2-R9M-ACCESS-noheli_release.bin.zip

all is fixed in the nighlies. I tried it recently and ACCESS works flawlessly including FLEX

jpmarotta commented 2 years ago

I can confirm that this issue also occurs on a mod'd TX16S which previously worked flawlessly on OTX. Same symptoms as above: able to "register", unable to bind. Tested with 2019 R9M on FCC and FLEX firmware. The following RXs were included in the testing in both FCC and FLEX:

  • R9MX OTA
  • R9 Slim+ OTA
  • R9 STAB

Here's my build if it's useful: edgetx-v2.5_tx16s_lua-ppmus-mode2-R9M-ACCESS-noheli_release.bin.zip

all is fixed in the nighlies. I tried it recently and ACCESS works flawlessly including FLEX

Just built and tested, works as expected. Looks like I'm staying on ETX. Thanks for the heads up!

jpmarotta commented 2 years ago

@b14ckyy

Have you been able to OTA firmware? Trying to change from FCC to FLEX, don't have the option to update OTA, only "internal" and "external module".

IMG_1044

pfeerick commented 2 years ago

I added/updated the code for some of the frsky update menus, but didn't enable the OTA ones as I don't have any hardware to test it.

Are you in a position to give it a try and see if if this works? I think it should at least add the menus - if anything works beyond that I have no idea! 😆 There be dragons ahead! ⚔️ 🐉

diff --git a/radio/src/gui/colorlcd/radio_sdmanager.cpp b/radio/src/gui/colorlcd/radio_sdmanager.cpp
index c3a7afc01..9cac1a279 100644
--- a/radio/src/gui/colorlcd/radio_sdmanager.cpp
+++ b/radio/src/gui/colorlcd/radio_sdmanager.cpp
@@ -337,20 +337,20 @@ void RadioSdManagerPage::build(FormWindow * window)
                   }
                 }
 // TODO: Integrate the remaining options
-#if 0
+#if 1
 #if defined(PXX2)
                 if (information.productFamily == FIRMWARE_FAMILY_RECEIVER) {
                   if (isReceiverOTAEnabledFromModule(INTERNAL_MODULE,
                                                      information.productId))
                     menu->addLine(
                         STR_FLASH_RECEIVER_BY_INTERNAL_MODULE_OTA, [=]() {
-                          FrSkyFirmwareUpdate(name, INTERNAL_MODULE_OTA);
+                          FrSkyFirmwareUpdate(name, INTERNAL_MODULE);
                         });
                   if (isReceiverOTAEnabledFromModule(EXTERNAL_MODULE,
                                                      information.productId))
                     menu->addLine(
                         STR_FLASH_RECEIVER_BY_EXTERNAL_MODULE_OTA, [=]() {
-                          FrSkyFirmwareUpdate(name, EXTERNAL_MODULE_OTA);
+                          FrSkyFirmwareUpdate(name, EXTERNAL_MODULE);
                         });
                 }
                 if (information.productFamily ==
@@ -360,14 +360,14 @@ void RadioSdManagerPage::build(FormWindow * window)
                       [=]() {
                         FrSkyFirmwareUpdate(
                             name,
-                            STR_FLASH_FLIGHT_CONTROLLER_BY_INTERNAL_MODULE_OTA);
+                            INTERNAL_MODULE);
                       });
                   menu->addLine(
                       STR_FLASH_FLIGHT_CONTROLLER_BY_EXTERNAL_MODULE_OTA,
                       [=]() {
                         FrSkyFirmwareUpdate(
                             name,
-                            STR_FLASH_FLIGHT_CONTROLLER_BY_INTERNAL_MODULE_OTA);
+                            EXTERNAL_MODULE);
                       });
                 }
 #endif
jpmarotta commented 2 years ago

@pfeerick Happy New Year! Heading to bed, will take a look tomorrow.

pfeerick commented 2 years ago

You too! :) And thanks... fingers crossed there's signs of life and not just a big fat error message ;)

jpmarotta commented 2 years ago

1) FLEX Firmware Issue

Output of CMake, got this warning. Might be the reason why an RX with FLEX firmware doesn't output signals to the flight controller. I have confirmed that there is RC control input at the FC using FCC firmware, and not when FLEX firmware is on the same RX (R9MX). I suspect that it is the same with EU LBT, but I'm not in a position to test.

INPUT: cmake -DPCB=X10 -DPCBREV=TX16S -DDEFAULT_MODE=2 -DGVARS=YES -DPPM_UNIT=US -DHELI=NO -DLUA=YES -DHARDWARE_EXTERNAL_ACCESS_MOD:BOOL=ON -DMODULE_PROTOCOL_FLEX:BOOL=ON -DCMAKE_BUILD_TYPE=Release ../

OUTPUT:

-- Generating done CMake Warning: Manually-specified variables were not used by the project:

MODULE_PROTOCOL_FLEX

-- Build files have been written to: /edgetx/edgetx-v2.6-RC1-R9Menus/build-tx16s root@cb8a019236e0:/edgetx/edgetx-v2.6-RC1-R9Menus/build-tx16s#

2) OTA Firmware Update UI Option - UPDATED:

So... bonehead move on my part, didn't change the case switch to "1". Rebuilt and now see the OTA option in the UI.

Here's the twist: when I try to update the R9MX receiver via OTA, the R9M TRANSMITTER module gets updated with the firmware payload. Obviously this causes the link to be lost. Re-flash the R9M with the correct FCC firmware and the RC link is re-established.

Here's the build for reference: edgetx-v2.6-RC1_tx16s_lua-ppmus-mode2-R9-ACCESS-OTA_release.bin.zip

pfeerick commented 2 years ago

For 1, MODULE_PROTOCOL_FLEX was removed in https://github.com/EdgeTX/edgetx/pull/1043 as FLEX is on by default now, thus the warning message from CMake.

For 2, ok, that makes sense looking at the OTA stuff a bit more... it looks like something else needs to be used for those updates - OtaUpdateInformation / Pxx2OtaUpdate seems to be the thing that is needed there, not the frsky update stuff like the updates...

Pxx2OtaUpdate otaUpdate(reusableBuffer.sdManager.otaUpdateInformation.module, destination->candidateReceiversNames[destination->selectedReceiverIndex]);

... so will have to investigate that a little further, and get back to you.

koroushbadi commented 2 years ago

Hi friends I need firmware edge tx for radio jumper t16 with noheli and externalaccessmod . Someone can help me and put BIN file for me Thank you

EnriqueBelli commented 1 year ago

Hi, Does anyone have the .Bin file of the edgetx firmware for a Radioking tx18s? (the same as the jumper T18) My radio has the access mode (hardware modification). I have already tried the different firmware proposed on this page and either I manage to register and bind my receiver (R9sx) and I have no output in S.Port (pwm) or I manage to register it but not bind it. I live in europe and I also tested the Fcc as recommended above it works but with a lot of latency and it's even dangerous 😐 (thanks to the 4G antenna at the bottom of my street) I don't really know much about programming or firmware modification so if someone would have the file thanks in advance ;-)

DM4DS commented 1 year ago

Hey.Have you tested versions I compiled?You find them on my homepage: www.dm4ds.deIt should "all" available included. Mine has the Bluetooth mod and works fine.If the versions don't work, send me an email and I try to compile one....GreetingsSandorDM4DS

EnriqueBelli commented 1 year ago

-Yes, I have already tested several versions that you have created (thanks for your excellent work by the way). With the 2.8 R9m access in EU flex mode it finds the receiver and registers it well but then it doesn't bind. :(

EnriqueBelli commented 1 year ago

---->Ok I succeeded in a special way, I went back to OpenTx taking my old model already Bind then I put back the firmware edgetx 2.8 that you created and converting the .bin file to .yml of my model, it kept the data relative to the bind and register of opentx so it works! Thank you very much for your reactivity and the enormous work that you contribute to provide on this forum. Great respect for you ;)

from Belgium

Translated with www.DeepL.com/Translator (free version)

DM4DS commented 1 year ago

Great that it works!

DNAcz commented 1 year ago

This is my third attempt to use ETX for T18 with external access mod and the R9 ACCESS is still not working. Where is the receiver registration in the menu? Is the R9 Flex supported?I'm going back to OTX again. :( Menu

MartyFufkin commented 1 year ago

I got it working by installing all the tools and compilers to make my own firmwares. It worked fine but I ended up getting too lazy and just changed everything to Crossfire (for better or worse) and it is just much easier now... That all said, if you follow the setup step by step, making your own firmware versions is not that hard. I'm just too lazy to do it all again.... I followed this process, and it all worked for me:

https://github.com/EdgeTX/edgetx/wiki/Build-Instructions-under-Windows-10-%28MSYS2%29

Then I just bought a Crossfire and a handful or receivers and bought my way out of the headache and removed the Access MODs from my TX16S. I also gave up on FRsky after the failed attempt to go all proprietary with their hardware and didn't want to keep going down that path (I get the irony with Crossfire, however).

DNAcz commented 1 year ago

Marty, thank you for your quick reply. I understand that sometimes it can be a waste of time. For me now the primary is ELRS but I would still like to use the R9 Access. I don't need a new Frsky radio for that. :)If it doesn't work out otherwise, I'll switch the R9 Access to ELRS.

b14ckyy commented 1 year ago

@DNAcz use this build from here https://www.dm4ds.de/wp/updated-edgetx-30-11-2022/

it has all the features enabled and ACCESS works just fine.

DM4DS commented 1 year ago

Thanks for using and spreading it.Happy driving/flying/racingSandor - DM4DS -- Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 06.12.22, 19:56 schrieb b14ckyy @.***>:

@DNAcz use this build from here https://www.dm4ds.de/wp/updated-edgetx-30-11-2022/ it has all the features enabled and ACCESS works just fine. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

DNAcz commented 1 year ago

DM4DS thank you very much. ETX is now for me too. Can you please show what cmake looks like for your compilation?

raphaelcoeffic commented 1 year ago

Gentlemen, are we still missing anything here, or should this be closed? For those interested, there is a new PR allowing for run-time configuration of the ACCESS mod, thus removing the need for a custom/self-compiled firmware. See #2562

b14ckyy commented 1 year ago

Not flight tested 2.8 in the field but on the bench it all seems to look good. Fine with me to close. Now we are just waiting for a proper and easy way to get our features set on demand instead of messing with command line stuff and compile ourselves ;)

gagarinlg commented 1 year ago

Not flight tested 2.8 in the field but on the bench it all seems to look good. Fine with me to close. Now we are just waiting for a proper and easy way to get our features set on demand instead of messing with command line stuff and compile ourselves ;)

we are working on it

EnriqueBelli commented 1 year ago

Thanks for using and spreading it.Happy driving/flying/racingSandor - DM4DS -- Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 06.12.22, 19:56 schrieb b14ckyy @.>: @DNAcz use this build from here https://www.dm4ds.de/wp/updated-edgetx-30-11-2022/ it has all the features enabled and ACCESS works just fine. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.>

Hi DM4DS,

First of all I would like to say thank you for all the work you've done, you've helped more than one person and that includes me! I'm sending you this message to know if it was possible to have the last firmware you created (30.11.2022) but with the internal gps instead of the bluethoot? Thanks in advance

Enrique

LordGG commented 1 year ago

Hi,

Gentlemen, are we still missing anything here, or should this be closed? For those interested, there is a new PR allowing for run-time configuration of the ACCESS mod, thus removing the need for a custom/self-compiled firmware. See #2562

2562 seems to be the solution for ACCESS modules, but what about non-ACCESS R9M that need the Flex option ?

I keep an old radio on OpenTX just for a few quads that are still running R9 Flex. I wish I could get rid of it ;)

pfeerick commented 1 year ago

You mean as far as showing the flex option? That is there by default now as of https://github.com/EdgeTX/edgetx/pull/1043

LordGG commented 1 year ago

You mean as far as showing the flex option? That is there by default now as of #1043

Oh, I didn't know about that change, thank you.

Then it should work, but it doesn't :/

RX is flashed with Flex F.Port firmware, but F.port shouldn't be a concern to the radio's firmware I guess.

If anyone has any idea about what is going wrong, it would be highly appreciated :)

pfeerick commented 1 year ago

Yes, I think there are some options missing still => https://github.com/EdgeTX/edgetx/issues/1187

On the Boxer, are you choosing R9M or R9M ACCESS? Mine is the red R9M, meaning it's the ACCESS version, and it does at least talk to the R9M module, but I also seem to be having issues with the RX maintaining lock with the 2.8.0 firmware, but a later development firmware seems to be stable (2.8.1 will include these changes, and is tentatively scheduled for release later this week).

LordGG commented 1 year ago

Yes, I think there are some options missing still => #1187

Thanks !

My R9M is also red but it is not the ACCESS version (first batches were black then red), so I choose R9M with all my radios.

I will wait for 2.8.1, hopefully it will solve the issues I have :)

raphaelcoeffic commented 1 year ago

It doesn't display "S. Port link" option.

Just to be clear: it's not an option, you cannot select anything. It is merely a piece of info telling you whether or not to expect telemetry from this module.

LordGG commented 1 year ago

Just to be clear: it's not an option, you cannot select anything. It is merely a piece of info telling you whether or not to expect telemetry from this module.

Thanks for clarifying. I didn't want to select it (or not), it was just a difference I had spotted between the Boxer and the Horus, in case it could help understanding what was going on :)

LordGG commented 1 year ago

Hi mates,

I have just tried 2.8.1 and the issue remains :

Setup : R9M (no ACCESS), Flex firmware, 868 Mhz, F.Port. If anyone has an idea, I take it :D Thanks ;)

raphaelcoeffic commented 1 year ago

@LordGG It seems this is due to some timing issues with PXX1 modules (XJT, R9M). If the inverters are sharper (shorter raise time) than those from the X10, then the pulse might appear longer, and could confuse the module. I could see something similar on the RM Boxer.

In OpenTx and older EdgeTx releases (incl. 2.8.1), the first pulse is supposed to be 9us. However, due to the different inverters, the effective length is different.

Here you see a couple example on main, with the pulse length reduced to 8us (what it should actually be):

If I test with 9 us pulses, it will work with the X10 and TX16S, but not with the Boxer. Using 8 us, it works with all of them.

I prepared a PR with the same changes as we did in main, but for 2.8.1, so that you can test: #3229. Please let me know if it works better for you.

LordGG commented 1 year ago

I prepared a PR with the same changes as we did in main, but for 2.8.1, so that you can test: #3229. Please let me know if it works better for you.

Thank you @raphaelcoeffic :) I'll let you know once I have tested it but it sounds promising. I guess I should wait for it to be merged into the main branch and then install a nightly build, right ?

raphaelcoeffic commented 1 year ago

Thank you @raphaelcoeffic :) I'll let you know once I have tested it but it sounds promising. I guess I should wait for it to be merged into the main branch and then install a nightly build, right ?

It would be much better if you could test before it's merged. PRs have automatic builds for this purpose.

LordGG commented 1 year ago

It would be much better if you could test before it's merged. PRs have automatic builds for this purpose.

Oops, I feel dumb, I'll be glad to test it as soon as possible but I don't know where to find those automatics builds :)

pfeerick commented 1 year ago

Please don't feel dumb... just ask ;)

To access the automatic builds for a PR (i.e. https://github.com/EdgeTX/edgetx/pull/3229), first open up the PR page. Under the PR title, you should see a series of tabs (Comments, Commits, Checks, Files Changed). Click on the Checks tab. Then if you are after the radio firmware, click on the link on the left side mentioning firmware. If you want a Companion/Simulator build, pick the one that suits your operating system. Then, under the 'Artifacts' heading will be a link to the zip file containing either the firmware or companion package.

tl;dr Click on this https://github.com/EdgeTX/edgetx/actions/runs/4234390140, scroll to the bottom of the page, and the firmware download package for the latest run is under the Artifacts heading

LordGG commented 1 year ago

Please don't feel dumb... just ask ;)

I had stopped half way (at the Checks tab). Thanks for the details :)

I have just tested it on my X10S Express and well done guys, it did the trick ! 💯 I can finally use all my modules with my radios. I haven't tested yet on my Boxer but I am not worried :)

I guess it will end up in the next official release ?

Again, thanks for your great work ! :)

raphaelcoeffic commented 1 year ago

I haven't tested yet on my Boxer but I am not worried :)

I figured so much: it does not work for me on the Boxer without, but works with the patch, so I guess we're covered.