EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.57k stars 333 forks source link

Difference at Telemetry ratio/instance between radio and companion #2665

Open elekSENDER opened 1 year ago

elekSENDER commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

In Model Settings/Telemetry parameter Ratio values are displayed in the radio 10x bigger than in companion. The value Instance is +1 displayed in the radio than in companion.

The displayed values in the radio of the active measured sensors are still correct in comparison to OTX.

grafik grafik grafik grafik

grafik grafik

Expected Behavior

same values in companion and radios

Steps To Reproduce

read/write companion/radio by changing parameter Ratio/Instance in telemetry

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

V2.8.0-RC3

this is a substitute for #1650

frankiearzu commented 1 year ago

Just FYI, This might have been solved by: https://github.com/EdgeTX/edgetx/pull/3615 The value is correctly converted by the firmware, instead of trying to fix it afterwards using ratio.

Fixes: ESC VBEC since it actually needed to be multiplied by 5 to get a decent value. For example, raw was 121, so 121*5=605, that with 2 decimal place is 6.05 that is the correct value. (and matches the Spektrum documentation, and testing with an Spektrum TX).

Also fixed the Erpm/PWM (needed x10, instead of /10), and Throttle power (%) was also erroneosly / 10. The values shown at the TX without any ratio are now correct.

elekSENDER commented 1 year ago

Fixes: ESC VBEC since it actually needed to be multiplied by 5 to get a decent value. For example, raw was 121, so 121*5=605, that with 2 decimal place is 6.05 that is the correct value. (and matches the Spektrum documentation, and testing with an Spektrum TX).

Great to hear that we don´t need this workaround anymore for correct Spektrum telemetry data. I tried this with a YGE-ESC and it worked very well.

This might have been solved by: #3615 The value is correctly converted by the firmware, instead of trying to fix it afterwards using ratio.

Yes, for Spektrum. But this issue is not solved in general, because i use ratio as well for FrSky telemetry sensors and the ratio difference between radio and companion still exists there.

aeropic commented 1 year ago

FDSCT3fjm0

Radiomaster TX16S / TX16SMK2 reproduced in TX16S MKII under EDGETX 2.8.4 Under companion : ratio = 0.1 while under the radio MMI the value is displayed in integer and the entered value is 1.