EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.5k stars 316 forks source link

Pasting or Editing LS or SF resets selected item #2808

Open MartinHugh opened 1 year ago

MartinHugh commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Two cases of the same problem. There may be more

These both apply to the Logical Switches page and the Special Functions page, and possibly others. A.

  1. Copy an item
  2. Select a cleared line and paste the item
  3. Note that the although the item just pasted is still visible in the list, the selected item is now the first in the list. To continue editing the newly pasted item one has to scroll from item 1 all the way to the item just pasted

B.

  1. Select and item and select Edit
  2. Edit the item and then cancel back to the list
  3. Note that the although the item just Edited is still visible in the list, the selected item is now the first in the list. To continue editing the newly pasted item one has to scroll from item 1 all the way to the item just pasted

This is hard work from a user workflow point of view: :-) I have just been editing 12 models, setting/editing LS 27 and 28 and SF 27/28. This took a while :-)

Expected Behavior

After pasting or editing Logical Switch line, or Special Function Line, that item should be the selected one. Not the first one, not any other one.

Steps To Reproduce

See current behaviour

Version

2.8.0

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

No response

ParkerEde commented 1 year ago

In the telemetry screen it is the same, when you search for new sensors and they are added, the marker in the screen jumps to the top. Here it would also be better if the mark remains on the button, so that you can end the sensor search right afterwards without having to select the button again.

gagarinlg commented 1 year ago

This seems to be fixed in the nightlies. @MartinHugh can you confirm?

MartinHugh commented 1 year ago

I think the bug has gone in the nightly. However I note there has been some change to long and short presses. So it took a while to work out how to do a copy. I think this will eventually be acceptable when people have got used to it, but usually not a good thing to change learned interaction methods during the life of a product.

It does work and the bug is gone, although when pasting one is now not able to select the target row by scrolling to it, one now has a list to choose from. This may be acceptable for some, personally I would prefer to scroll to the actual target row. This is usually because a) I am copying to the row below. Or b) I want to group related rows together and I want to see the rows around where the new one will go.