search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.58k stars 333 forks source link

EL18 cannot achieve 5.25M BAUD for CRSF #2861

Closed richardclli closed 1 year ago

richardclli commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Can only achieve 1.87M BAUD, error occurs when trying to use 3.75M BAUD or 5.25M BAUD.

Expected Behavior

Hardware is similar to TX16S, both uses USART2, it should works the same way as TX16S

Steps To Reproduce

  1. External Module
  2. Select CRSF
  3. Select BAUD to 3.75M BAUD or 5.35M BAUD
  4. ELRS will report connection problem.

Version

2.8.0

Transmitter

Flysky EL18

Anything else?

No response

richardclli commented 1 year ago

I think it is because it uses its own telemetry driver, should unify to horus driver to support same features. Will work out a PR soon.

richardclli commented 1 year ago

@pfeerick I think this need to be fixed in 2.8.1

richardclli commented 1 year ago

I will work out another PR forv2.8 branch

richardclli commented 1 year ago

Added a PR for branch 2.8

richardclli commented 1 year ago

@pfeerick I think this can be closed, as the new serial driver solves this problem in main and 2.8 already has the fix applied.

pfeerick commented 1 year ago

Ah yes, thanks... yeah, the PR got close since the serial driver changes superceeded it.