search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.59k stars 338 forks source link

Horus X12S 6 position switch numbers freezing again since nightly update change. #2943

Closed Kevltan closed 1 year ago

Kevltan commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Moving the selector knob sometimes fails to index the numbers on the screen. Next click jumps over the missed digit.

Expected Behavior

To index numbers on screen reletive to knob position. Was fine in 2.8.0 after firmware was changed due to a similar problem. I have reverted back to 2.8.0 and works perfectly again. I like the new graphical/numerical representation in the 2.9 nightly though👍

Steps To Reproduce

As above.

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X12

Anything else?

2.9 nightly selfbuild used. Calibration does not solve the issue. 25-12-22

eshifri commented 1 year ago

Interestingly enough, calibration in the TX16S simulator is broken completely: the 6POS is stack at 2 in the calibration screen and at 1 in the main screen. I doubt it can be related to the UI change.

philmoz commented 1 year ago

@eshifri In the simulator calibration try setting the 6POS switch to position 4 when asked to center all controls. Make sure to move the 6POS knob to all 6 positions when asked to move all the controls.

eshifri commented 1 year ago

@philmoz Now it is stack in pos 4 in both screens. :-)

philmoz commented 1 year ago

@eshifri Very strange. When I calibrate it I move the 6POS knob slowly through each position a few times. I set it to 4 on the center screen then on the move screen I go 3, 2, 1, 2, 3, 4, 5, 6, 5, 4, 3, 2, 1, 2, 3, 4, 5, 6 and it calibrates fine. I avoid jumping randomly between values and also avoid jumping directly from 0 to 6 or 6 to 0 (which the knob control allows). Using the scroll wheel on the mouse seems the easiest method for me.

eshifri commented 1 year ago

Thank you! I got it working after rebuilding simulator and companion in addition to libsimulator.

Kevltan commented 1 year ago

Have you updated the nightly as the same problem still exists? For instance if it gets stuck on 6 I have to go to 4 and then return to 6 before I can get 5 position. This is not always true and can do it between any numbers. Still works in 2.8 consistently.

On Mon, 26 Dec 2022, 05:58 eshifri, @.***> wrote:

Thank you! I got it working after rebuilding simulator and companion in addition to libsimulator.

— Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/2943#issuecomment-1364913193, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANPFAW62Y4ATQ4JBV23WVADWPEXZ7ANCNFSM6AAAAAATJDVMJQ . You are receiving this because you authored the thread.Message ID: @.***>

eshifri commented 1 year ago

@Kevltan It was my problem only: I was using old cpn and simulator builds. Nightly should be up-to-date. An this was a simulator only problem. I thought it might have been related to your observation - looks like it was not the case.

Kevltan commented 1 year ago

Yes it is definately related to the 2.9 nightly build as have again gone back to 2.8.0 and it works flawlessly. Something must have been changed or is in someway related to other recently edited code/parameters that are used to display position on the TX LCD panel. Its almost like the encoded position tolerance has been changed or is not equal between the selected 1 - 6 detents. Actual/real positional ouput is not effected.

eshifri commented 1 year ago

@Kevltan I have a suspicion, but I do not have Horus. So,

  1. Do you have any way to check whether this is a display issue only, or the position is also incorrect?
  2. Would you be able to test if I create a branch?
Kevltan commented 1 year ago

Radio output positions correct. 100%, 60%, 20%, -20%, -60%, -100%. It is on the display itself bottom middle above 6 position switch knob. The 2.8.0 version had only lines with the selected number highlighted on its respective line. 2.9 has all the numbers 1- 6 instead of lines and number active is highlighted.

Kevltan commented 1 year ago

will edit above and retry

eshifri commented 1 year ago

I think I was able to reproduce it on TX16S (to some extent) and I have submitted the PR #2947 . It will be compiled shortly. Would be great if you can give it a try on Horus.

Kevltan commented 1 year ago

Have edited and rebuilt firmware. Absolutely solved the probem, superb @eshifri cracking piece of work 👌👍😁 Can you sort the IMU problem logged earlier in bugs #2786? 🤔😉