EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.6k stars 341 forks source link

Misleading "RX channel order" on BW radio #3348

Closed 3djc closed 1 year ago

3djc commented 1 year ago

Is there an existing issue for this feature request?

Is your feature request related to a problem?

The working used is misleading and technicaly not accurate imho. All this field does is define a default RADIO channel order, but actual RX channel order might be affected by things like multimodule channel reordering, or receiver side pin mapping on ELRS and others. In no way can it be guarented that RX will actually use the order shown here.

image

(Don't look at the RETT value, this is a WIP branch ;))

Describe the solution you'd like

Remove RX from the wording

Describe alternatives you've considered

No response

Additional context

No response

pfeerick commented 1 year ago

Color has the proper wording "Default channel order" .... has never been changed from the OTX wording, which I guess was done that way to struggle to condense "Default channel order" for 128x64??

Anyway, since 15 chars seems to to be the visual limit I'm tempted to change it "Def chnl order"

https://github.com/EdgeTX/edgetx/blob/b258c3b92c6b4bf0e6fb0d5801d6117fcdfa8519/radio/src/translations/en.h#L457

3djc commented 1 year ago

Maybe 'Def chan order' ?

pfeerick commented 1 year ago

Sounds good to me. I'll include that in #3326 as it will need some translations done anyway.