EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.6k stars 340 forks source link

Channel monitor graphical/display glitches #3450

Closed bigtwin closed 1 year ago

bigtwin commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

The problem is already reported/fixed with OTX 2.3.9 Channel monitor graphical/display glitches

I just upgraded my Taranis x9lite (Access) to ETX 2.8.2 and experienced the same. I cannot say whether the problem already existed with ETX 2.7.1 which I had before.

Expected Behavior

Properly displayed channel monitor

Steps To Reproduce

Simply "page" main screen to the channel monitor

Version

2.8.2

Transmitter

FrSky X9 Lite / Lite S

Operating System (OS)

macOS

OS Version

No response

Anything else?

No response

pfeerick commented 1 year ago

The fix that was applied there is present in ETX, so perhaps it needs to be expanded a little wider to not just be limited to the X7 and X9LITES https://github.com/EdgeTX/edgetx/blob/f01b0f27722e9e5e6d8e1e7b4c3ed53267525645/radio/src/gui/128x64/widgets.cpp#L71-L75

pfeerick commented 1 year ago

Are you able to flash this firmware, and let me know if that fixes the issue for you? x9lite-2.8.2-test.zip

diff --git a/radio/src/gui/128x64/widgets.cpp b/radio/src/gui/128x64/widgets.cpp
index 663ca73f5..e30a17c29 100644
--- a/radio/src/gui/128x64/widgets.cpp
+++ b/radio/src/gui/128x64/widgets.cpp
@@ -68,7 +68,7 @@ void drawVerticalScrollbar(coord_t x, coord_t y, coord_t h, uint16_t offset, uin

 void drawGauge(coord_t x, coord_t y, coord_t w, coord_t h, int32_t val, int32_t max)
 {
-#if defined(PCBX7) || defined(PCBX9LITES) // X7 LCD doesn't like too many horizontal lines
+#if defined(PCBX7) || defined(PCBX9LITE) || defined(PCBX9LITES) // X7 LCD doesn't like too many horizontal lines
   h++;
 #else
   lcdDrawRect(x, y, w+1, h);
bigtwin commented 1 year ago

Hello @pfeerick! Thx for taking care that fast! I could test it right away and can confirm - problem resolved :-)

pfeerick commented 1 year ago

No problem, thanks for the quick test. A fix will be present in 2.8.3 and 2.9.x. You should be able to safely use the firmware I sent you if you wish as it is 2.8.2 with some 2.8.3 fixes applied.

bigtwin commented 1 year ago

How is your preferred workflow? Should this issue remain open till 2.8.3 is released, will you close it or am I supposed to close the issue since I started it? I am supporting a collegue who is working on a german translation of the ETX manual and I am depending on a german install. Therefor I will roll back to official 2.8.2 and patiently waiting for 2.8.3 :-)

richardclli commented 1 year ago

How is your preferred workflow? Should this issue remain open till 2.8.3 is released, will you close it or am I supposed to close the issue since I started it? I am supporting a collegue who is working on a german translation of the ETX manual and I am depending on a german install. Therefor I will roll back to official 2.8.2 and patiently waiting for 2.8.3 :-)

You just leave the closing of an issue to us, we will manage it thanks.