EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.57k stars 333 forks source link

widgets vs. sensors (TX16s/FS-IA6B FW2.8.3) #3543

Closed ivanb123github closed 1 year ago

ivanb123github commented 1 year ago

Is there an existing issue for this problem?

What part of EdgeTX is the focus of this bug?

Build system

Current Behavior

I tried FW 2.8.3 for TX16s with RX FS-IA6B and it maps telemetry data to widgets incorrectly. This is a telemeter. data from the sensor of my construction. So I reverted back to FW 2.8.2 and everything works OK again.

Expected Behavior

see above

Steps To Reproduce

  1. upload firmware 2.8.3 from https://github.com/EdgeTX/edgetx/releases/tag/v2.8.3

Version

2.8.2

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

3djc commented 1 year ago

image

image

Seems to work ok

pfeerick commented 1 year ago

Note that this is in relation to Flysky telemetry (not Frsky) - so not necessarily indicative of an issue with that setting (other than it not recognising the values as being valid GPS data).

richardclli commented 1 year ago

Note that this is in relation to Flysky telemetry (not Frsky) - so not necessarily indicative of an issue with that setting (other than it not recognising the values as being valid GPS data).

Ideally, since the sensors are not produced by Flysky (3rd party). It will be nice to make use of the Frsky GPS sensors formatting, but I cannot figure out a way to generic way to work this out. So leave it as RAW so it is readable.

Maybe the sensors need a refactoring. ^.^

pfeerick commented 1 year ago

Maybe the sensors need a refactoring. ^.^

Surely not! 🤪 🤣

ivanb123github commented 1 year ago

for 3dj:

  1. For what type of TX and RX.
  2. For what type of sensor.
frankiearzu commented 1 year ago

Looks like this might have been solve by #4062

pfeerick commented 1 year ago

Indeed it does look like https://github.com/EdgeTX/edgetx/pull/4080 seem to have finally been put this issue to rest, thanks to your efforts and those who helped in #4062 to test it.