EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.63k stars 344 forks source link

Change trainer modes from Master / Slave to Trainer / Student #3609

Closed phileville closed 1 year ago

phileville commented 1 year ago

Is there an existing issue for this feature request?

Is your feature request related to a problem?

The terms Master & Slave are not so descriptive and can be a bit confusing when configuring trainer mode. Trainer and Student is a clearer description for the modes. Additionally, in most tutorials it is referred to as student / trainer or instructor and not Master / Slave. Nobody says " On the Slave radio, go to model settings...."

Describe the solution you'd like

Change the configuration settings from Master to Trainer and Slave to Student.

Describe alternatives you've considered

No response

Additional context

The German translation already is using those terms Lehrer and Schüler

3djc commented 1 year ago

The issue is some clubs have training planes bound to teachers radio, others where the students come with their model (and therefore their radio is bound to model (that's how I was reached actually). That's why those words where choosen

phileville commented 1 year ago

But in that case where the student's radio is bound to the plane and configured as Master, with the instructor configured as slave, how does the the instructor take over when the student is in trouble? The SF to activate / deactivate trainer mode is on the Master radio. Or is there a different way to configure this?

3djc commented 1 year ago

I was using a Graupner when I was trained, and my trainer a Multiplex. The trainer switch was on my radio, more often than not, it was me requesting him to take over, but a few time he also asked me to give him back the plane. That works fine, the added benefit was that I knew my plane exactly when I graduated.

While I haven't tried it, you can probably use a slave channel to trigger trainer on master radio, so the trainer (slave in this case) can decide on training mode. I can try it if you want

ReneNwnhs commented 1 year ago

You don't use this type of connection exclusively in training situations. Models that require "more hands" for some reason can have two transmitters connected and controlling the model. For instance: one is flying, the other is controlling the camera's. Or maybe a scale-model with extra features?

ror1948 commented 1 year ago

my vote is leave as is...master/slave is standard for all Tx. Let's not just change for the sake of change.

Eldenroot commented 1 year ago

Leave it, do not change

pfeerick commented 1 year ago

I would probably have to agree with the "not change for the sake of change" sentiment. While I do agree that some other systems often refer to it as student and trainer radio, the convention for OTX and now ETX has always to refer to the primary radio as the master, and the secondary as the slave... as that makes more sense than primary and secondary ;) And yes, sometimes it is in reverse, the student's radio is actually the transmitting one, and the trainer's radio is the "slave", which would then introduce confusion. IMO we would have to gradually transition over in the documentation and ensure there was plenty of videos and guides, etc, using that wording before we could even contemplate changing it. And even then there just seems like there may be too much room for confusion?

ReneNwnhs commented 1 year ago

As far as i can see the titles trainer/student are causing the confusion. Trainer ánd student are roles performed by persons handling a device. All that these actors do, is creating input that the device is interpretating based on rules. Only one device is in control of the model and only one device is mastering the communication. And the communication is what its all about. The device mastering, allowes incoming signals (from a tx acting as a rx or a 3,5 mm jack) to override its own input to the tx controling the model. Ór using these inputs (TR..) for other means or even not at all. Even if a student is handling the master device, this device is interpretating the rule that "If there is an incoming trainersignal, it has priority over the studentsignal". If there is no signal for whatever reason (communication-failure would be catastrofic), the student is in control. The device is still the master, no matter what.

phileville commented 1 year ago

Thank you everyone for your thoughts and feedback on this issue. It gave me some additional perspectives that I had not considered. Based on that I would agree that we should just keep it as it is. I will close this request.

Schlaegel commented 1 year ago

I've been bothered by the slavery terms in tech. The terms "primary" and "secondary," which were used by [pfeerick] to explain master and slave are general enough to be useful in many contexts, while also avoiding really horrible slavery analogies.

ror1948 commented 1 year ago

If we must change then pick "instructor" and "student". Spektrum use that now in all there talking radios.

ReneNwnhs commented 1 year ago

It's all about a relationship between devices in a communication scenario. Neather is learning or teaching the other anything, so ... What is this supposed to accomplish by changing clear terms into misty words?

ror1948 commented 1 year ago

oh but it is for buddy box setup and yes there is a teacher and student. i say it is ok as is but if we must change.

ReneNwnhs commented 1 year ago

As I in my earlier post said you can connect two transmitters for other then training purposes, and i do. One of them does the flying, the other controlls the weaponary and such. Never mind, it's not worth arguing about. Let the team take a pick if it's so important.