search

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio
https://edgetx.org
GNU General Public License v2.0
1.58k stars 336 forks source link

New models to fill gaps of deleted models #366

Open Mantamatt1 opened 3 years ago

Mantamatt1 commented 3 years ago

Tx16s Rc3 but unchanged from otx Not sure if this is a feature request or a bug?

When you create a new model it has a model number I.e model25 ( I use this number as the receiver number aswell. (wish it would do it automatically). When you delete a model let's say model15 And create a new model it will create model26

It doesnt fill in the gaps so model15 would just be a gap and the model numbers keep going up and up. On my qx7 I could fill in the gaps and receiver number would match and not be random manual selection

pfeerick commented 3 years ago

I would say if it's a behaviour from OTX, then we can call it both a fix of their bug, as well as an 'enhancement' ;) I like the idea - if only from a OCD / neat freak standpoint... since there's going to be gaps in the filenames, as well as the 'blank' titles ;)

Mantamatt1 commented 3 years ago

Its definitely an ocd thing lol Soon I'm going to be on model1324 just through etx testing lol

sfjuocekr commented 3 years ago

I've reported this to OpenTX in the past, but they were not willing to change it.

Maybe when the models are read it could just parse the entire directory and name them according to UUID.bin?

pfeerick commented 3 years ago

That' s one way to do it. The other is to simply fill in the gap when chosing the next number. Was this an an issue - I'm curious as to the reasoning (of any was given) - as all I can think of is perhaps something to do with synchronization - either with the models.txt index file or perhaps some other edge cases.

sfjuocekr commented 3 years ago

Parsing a directory to look for an empty "slot" is one way to do it, it does introduce extra code to manage models.

I don't think it is an issue, it just does not look nice to have a whole bunch of modelXYZ.bin files that are unused after deleting a model.

Mantamatt1 commented 3 years ago

And the fact that I match the model number with receiver number so I'm not aimlessly looking for an unused ex number and it messes with my OCD lol

On Tue, 13 Jul 2021, 17:21 Sjoer van der Ploeg, @.***> wrote:

Parsing a directory to look for an empty "slot" is one way to do it, it does introduce extra code to manage models.

I don't think it is an issue, it just does not look nice to have a whole bunch of modelXYZ.bin files that are unused after deleting a model.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EdgeTX/edgetx/issues/366#issuecomment-879226232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUT54YA5FPXTWHPTRJM7LUTTXRR2DANCNFSM47NT7CHA .